[opensuse-kernel] openSUSE 12.1 kernel update - regression in suspend
Hi, We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram. bnc#764864 and lots of duplicates. Please check ASAP. (I can disable the update for now in the repo if you think this is a good idea.) Ciao, Marcus -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now... - -- js suse labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP6iceAAoJEL0lsQQGtHBJ/mQP/jjyITk1JFUYfEyJCRs+Pap4 +xtjYJVJa4gGwnU8ZYX1tKANCq3YEIiqJroLRCRQPUahCwDegci9vJ2DIq8DpymG jx8eQ6rjFFE0WJn67Nb2ha4G9qB8C5a9PfQz9dKLS6WExzVulQzOT1+TOtgGajdu qR/2IYAD35IfdyRjEFks6fYsG2sVF79PQ7FViSbx6TsNeCUXOqrykSMR3S/VXAnO aMFwwwq8zdtL+1mldLpsNhlS+gZSH+2oCUdyPD25NKkgPNcoq3Ugj7Bd9xZpV+2K J7x29D4H93Si7wLfKdxRFN8pDCMnfOxPj+wcCjTqGiXOBfDT0F1UE81iNVdwDCFy V6/kvUDW4RqoV0iVAT11WgjybLSe3qW6Cyao1xTs145UycA5JQ+tdd+8BvsRF/F9 ltPru5YeGqB2l4xr3PDnO9Z9pdVZUIi2VREVioERn+WZe0vgJyLOe3erdgHO9yS9 rK4XI5zlZYgdq1b8XQJhbJH+r89uPtXJBWrUptVDNLzBV4AY6wziZZxWzPufBMIh QoWN3+fdVtc5g66alFaKQhc4G/ElqRTr0WMiWNWMRVYGe6c9Gx+t8E0z/HtCIqgF fn2AJL7/rZUm/zjyHe1P3cISXbYLr7oDbpGQ9N7ldhsIPu/23/18EGxrnKt0LmPW t9BJ14rTQiT3wpxPTUgt =Jwxb -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Tue, Jun 26, 2012 at 11:18:22PM +0200, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now...
Jeff, can you submit a new update (maintenancerequest)? Ciao, Marcus -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 6/26/12 5:18 PM, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now...
I'm afraid not. This is an issue severe enough that we revoked a
maintenance update and I don't see a mention of that bnc (or related)
in the changelog. I'm not going to push it as a maintenance update
until there's a entry in the changelog with a bugzilla reference that
shows the casual user that this problem has been fixed.
Is this the relevant fix? If so, please document it.
commit 254aa615b747af471469cd6d0bfb6054547d8366
Author: Mike Galbraith
On Tue, 2012-06-26 at 23:17 -0400, Jeff Mahoney wrote:
On 6/26/12 5:18 PM, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now...
I'm afraid not. This is an issue severe enough that we revoked a maintenance update and I don't see a mention of that bnc (or related) in the changelog. I'm not going to push it as a maintenance update until there's a entry in the changelog with a bugzilla reference that shows the casual user that this problem has been fixed.
Is this the relevant fix? If so, please document it.
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
commit 254aa615b747af471469cd6d0bfb6054547d8366 Author: Mike Galbraith
Date: Tue Jun 26 05:31:23 2012 +0200 Remove dud patch. The problem it addressed is being respun upstream, is in tip, but not yet mainlined.
Delete
patches.fixes/cpusets-Dont-touch-cpusets-during-suspend-or-resume.patch.
-Jeff
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 6/27/12 12:07 AM, Mike Galbraith wrote: > On Tue, 2012-06-26 at 23:17 -0400, Jeff Mahoney wrote: >> On 6/26/12 5:18 PM, Jiri Slaby wrote: >>> On 06/25/2012 01:10 PM, Marcus Meissner wrote: >>>> We are getting lots of bugreports that the current 12.1 >>>> kernel update breaks suspend to ram. >>> >>>> bnc#764864 and lots of duplicates. >>> >>> We should be fine by now... >> >> I'm afraid not. This is an issue severe enough that we revoked a >> maintenance update and I don't see a mention of that bnc (or >> related) in the changelog. I'm not going to push it as a >> maintenance update until there's a entry in the changelog with a >> bugzilla reference that shows the casual user that this problem >> has been fixed. >> >> Is this the relevant fix? If so, please document it. > > Aw poo, no bug reference, and not verbose enough. Yeah, removing > the dud patch is the fix. Hm, so to properly document, edit > kernel-source.changes and push again, or revert and redo from > scratch? All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break things since you've already pushed. If that works, it'd be ideal. Otherwise, a "previous commit did xyz (bnc#...)" commit will probably be the cleanest. - -Jeff >> commit 254aa615b747af471469cd6d0bfb6054547d8366 Author: Mike >> GalbraithDate: Tue Jun 26 05:31:23 2012 >> +0200 >> >> Remove dud patch. The problem it addressed is being respun >> upstream, is in tip, but not yet mainlined. >> >> Delete >> >> patches.fixes/cpusets-Dont-touch-cpusets-during-suspend-or-resume.patch. >> >> >> - -Jeff >> > > - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP6ofXAAoJEB57S2MheeWyMBQP/iUb1Dg8Mqn7hlZo0syQ3pdU wVP/VdXWRl2kh8qbvHOdpirkpyaKTUgFR68ejGfE2ofTu5b6WnIuYOerq10rmaiO YangC+3z32L+rNOR1sYEabvK2b7I2oynT5d67drE4ul+PFhIreEhvUi2li0+XQFZ MCJhH6BsoZZusSQfob5hL4Ak9jiY/Z8feFG7zWhJAe1Z3NN1rZic5/nZHz4ZNrJR jTEBUA1150NoFvhxUcePTVGX8MmP2XGW5MtpOY692jw6Y1YS8qBrIKlK6WQYYObw VY2HMI+bKuz7kMJwhTRJ2BOKMDN+xx+ZEDk0hDtEM8CmGEGDz/YJshXgb5EE8vwi 5vfSH95sW+yyQsOXHMOfbAIsyRuDZU/vKF4YmFXMBG4EGlDze3N0PKwVX4iuOYGp x2PZ9UWkIHkIoTKyI/GS1QZjpea6rUXby/0Wi3lRL2sF/rsNajEbrNQk3LqUa9sw ew2vTP6tmrmOizbw03Az4LPxImPtcJ+fICcNXXzCAXoSDZKBF/hjHPMh6py4/l7x IASl1mrl/Z5dIi3/NURc3VkSZRQ3hc/aKcDgrz0Xuawsk1iKPrBnt+rrUsLzFqtB JhqgO2HoaD6cqIgisSdzId57aD3C4IRb2OUybq2G/Mtz8UpiZdjILW/+aUKkO+Wz ll6KX7dO6NvkHPc2suMv =lI6l -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Wed, 2012-06-27 at 00:11 -0400, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
On Tue, 2012-06-26 at 23:17 -0400, Jeff Mahoney wrote:
On 6/26/12 5:18 PM, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now...
I'm afraid not. This is an issue severe enough that we revoked a maintenance update and I don't see a mention of that bnc (or related) in the changelog. I'm not going to push it as a maintenance update until there's a entry in the changelog with a bugzilla reference that shows the casual user that this problem has been fixed.
Is this the relevant fix? If so, please document it.
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break things since you've already pushed. If that works, it'd be ideal. Otherwise, a "previous commit did xyz (bnc#...)" commit will probably be the cleanest.
If that's now acceptable, I'll try to push.
commit cd12a46f207e18f4d4e4c3ca6a670a12ed848c84
Author: Mike Galbraith
On Wed, 2012-06-27 at 06:56 +0200, Mike Galbraith wrote:
On Wed, 2012-06-27 at 00:11 -0400, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
On Tue, 2012-06-26 at 23:17 -0400, Jeff Mahoney wrote:
On 6/26/12 5:18 PM, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now...
I'm afraid not. This is an issue severe enough that we revoked a maintenance update and I don't see a mention of that bnc (or related) in the changelog. I'm not going to push it as a maintenance update until there's a entry in the changelog with a bugzilla reference that shows the casual user that this problem has been fixed.
Is this the relevant fix? If so, please document it.
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break things since you've already pushed. If that works, it'd be ideal. Otherwise, a "previous commit did xyz (bnc#...)" commit will probably be the cleanest.
If that's now acceptable, I'll try to push.
commit cd12a46f207e18f4d4e4c3ca6a670a12ed848c84 Author: Mike Galbraith
Date: Tue Jun 26 05:31:23 2012 +0200 This commit fixes suspend to ram breakage reported in bnc#764864.
Remove dud patch. The problem it addressed is being respun upstream, is in tip, but not yet mainlined. See bnc#752460 for details regarding the problem the now removed patch fixed while breaking S2R.
Delete patches.fixes/cpusets-Dont-touch-cpusets-during-suspend-or-resume.patch.
Hm.. strange. git commit --amend followed by git log, shows one commit
with amended log. Perfect. Then git pull, one becomes two commits each
doing the same thing per git show.
I'm not at all sure what this will do if I push it.
commit d0160785c29429447c2e479c977d5e07dab7b40a
Merge: 1e8509b 254aa61
Author: Mike Galbraith
On 27/06/12 13:17, Jeff Mahoney wrote: [........]
- -Jeff
- -- Jeff Mahoney SUSE Labs
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools -http://gpgtools.org Comment: Using GnuPG with Mozilla -http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJP6ntAAAoJEB57S2MheeWypbkP/iQv+pUZCxb8JCbv3a8KJgXR WaGHwFAavIOBQqRqXJD3FqT80M7I4Megz6Is4LQRzeOYxM9+rPtb/VbYDOyrym9V Ki/sJ1RT1REjVnHBF02EctMfqjepTJL20JU2IYMNGIWXcmctoxbP5Q3jIQ45LE40 Uyv9MAiUeTpwEjobp13wX77ER9fL+qiEq++A1qnPICuPKoaeuuawTy710G66c7G7 sqr84AqPUJTbJx253DLQHc4IOKLiFfw0KLbgMMkLEM8xPrv0podGmPPeVw8p+9lx AabyB+NOdrVcPm9pVRmNCTpsTK6PfhIxy99+VeprRU044HEpbiixLM1lSIPEWbiR skVoctiTc3Qms0tb9CXZMHgJoVPyNP4f1Q/7p0s0bmUWVJ7vkS9qB55A2qWt27cS xpGsXIgbBiTj2hXF1mqskv/Ne+ek/3fA70sDfC0e4nE3iu6m1f958ZI6CRYkIvyT GAwLP0WMw5pXZptNtRZtg8i/yej1qGlHROTcc4P8ZqlzZQBzeVUYLB9t/RXvLdM7 5BcBBY2jCg9mFeTOpsQaXr2VFFeeVcdaAWpNCjP13OEQEAf9DV9Ut/xXS860RPP6 p4aIiWcGfCXC1KsezISpfLWyGUd1wATlKmcaQbups4HvbbcW02YQVaTdbBaobo/G /jLZnmzyVJVJ9eGTLrMp =2/tm -----END PGP SIGNATURE-----
Please forgive me for asking this question. I really do not know anything about encoded mail and therefore have no idea where the problem may lie. But is it really necessary for a message sent to, say, this mail list which contains all of the text as shown above? I know that the posting rules for openSUSE lists suggests that the max number of lines in a signature be limited to 4 lines but the above is simply ridiculous. BC -- Using openSUSE 12.2 x86_64 KDE 4.8.4 and kernel 3.4.4 on a system with- AMD FX 8-core 3.6/4.2GHz processor 16GB PC14900/1866MHz Quad Channel Corsair "Vengeance" RAM Gigabyte AMD3+ m/board; Gigabyte nVidia GTX550Ti 1GB DDR5 GPU -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Disregard, pushed. On Wed, 2012-06-27 at 07:58 +0200, Mike Galbraith wrote:
On Wed, 2012-06-27 at 06:56 +0200, Mike Galbraith wrote:
On Wed, 2012-06-27 at 00:11 -0400, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
On Tue, 2012-06-26 at 23:17 -0400, Jeff Mahoney wrote:
On 6/26/12 5:18 PM, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote: > We are getting lots of bugreports that the current 12.1 > kernel update breaks suspend to ram.
> bnc#764864 and lots of duplicates.
We should be fine by now...
I'm afraid not. This is an issue severe enough that we revoked a maintenance update and I don't see a mention of that bnc (or related) in the changelog. I'm not going to push it as a maintenance update until there's a entry in the changelog with a bugzilla reference that shows the casual user that this problem has been fixed.
Is this the relevant fix? If so, please document it.
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break things since you've already pushed. If that works, it'd be ideal. Otherwise, a "previous commit did xyz (bnc#...)" commit will probably be the cleanest.
If that's now acceptable, I'll try to push.
commit cd12a46f207e18f4d4e4c3ca6a670a12ed848c84 Author: Mike Galbraith
Date: Tue Jun 26 05:31:23 2012 +0200 This commit fixes suspend to ram breakage reported in bnc#764864.
Remove dud patch. The problem it addressed is being respun upstream, is in tip, but not yet mainlined. See bnc#752460 for details regarding the problem the now removed patch fixed while breaking S2R.
Delete patches.fixes/cpusets-Dont-touch-cpusets-during-suspend-or-resume.patch.
Hm.. strange. git commit --amend followed by git log, shows one commit with amended log. Perfect. Then git pull, one becomes two commits each doing the same thing per git show.
I'm not at all sure what this will do if I push it.
commit d0160785c29429447c2e479c977d5e07dab7b40a Merge: 1e8509b 254aa61 Author: Mike Galbraith
Date: Wed Jun 27 07:21:40 2012 +0200 Merge branch 'openSUSE-12.1' of kerncvs.suse.de:/home/git/kernel-source into openSUSE-12.1
commit 1e8509b9883f55e5ebbaa9d72d173ed28b980c2c Author: Mike Galbraith
Date: Tue Jun 26 05:31:23 2012 +0200 This commit fixes suspend to ram breakage reported in bnc#764864.
Remove dud patch. The problem it addressed is being respun upstream, is in tip, but not yet mainlined. See bnc#752460 for details regarding the problem the now removed patch fixed while breaking S2R.
Delete patches.fixes/cpusets-Dont-touch-cpusets-during-suspend-or-resume.patch.
commit 254aa615b747af471469cd6d0bfb6054547d8366 Author: Mike Galbraith
Date: Tue Jun 26 05:31:23 2012 +0200 Remove dud patch. The problem it addressed is being respun upstream, is in tip, but not yet mainlined.
Delete patches.fixes/cpusets-Dont-touch-cpusets-during-suspend-or-resume.patch.
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Le mercredi 27 juin 2012 à 17:56 +1000, Basil Chupin a écrit :
On 27/06/12 13:17, Jeff Mahoney wrote:
[........]
- -Jeff
- -- Jeff Mahoney SUSE Labs
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools -http://gpgtools.org Comment: Using GnuPG with Mozilla -http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJP6ntAAAoJEB57S2MheeWypbkP/iQv+pUZCxb8JCbv3a8KJgXR WaGHwFAavIOBQqRqXJD3FqT80M7I4Megz6Is4LQRzeOYxM9+rPtb/VbYDOyrym9V Ki/sJ1RT1REjVnHBF02EctMfqjepTJL20JU2IYMNGIWXcmctoxbP5Q3jIQ45LE40 Uyv9MAiUeTpwEjobp13wX77ER9fL+qiEq++A1qnPICuPKoaeuuawTy710G66c7G7 sqr84AqPUJTbJx253DLQHc4IOKLiFfw0KLbgMMkLEM8xPrv0podGmPPeVw8p+9lx AabyB+NOdrVcPm9pVRmNCTpsTK6PfhIxy99+VeprRU044HEpbiixLM1lSIPEWbiR skVoctiTc3Qms0tb9CXZMHgJoVPyNP4f1Q/7p0s0bmUWVJ7vkS9qB55A2qWt27cS xpGsXIgbBiTj2hXF1mqskv/Ne+ek/3fA70sDfC0e4nE3iu6m1f958ZI6CRYkIvyT GAwLP0WMw5pXZptNtRZtg8i/yej1qGlHROTcc4P8ZqlzZQBzeVUYLB9t/RXvLdM7 5BcBBY2jCg9mFeTOpsQaXr2VFFeeVcdaAWpNCjP13OEQEAf9DV9Ut/xXS860RPP6 p4aIiWcGfCXC1KsezISpfLWyGUd1wATlKmcaQbups4HvbbcW02YQVaTdbBaobo/G /jLZnmzyVJVJ9eGTLrMp =2/tm -----END PGP SIGNATURE-----
Please forgive me for asking this question.
I really do not know anything about encoded mail and therefore have no idea where the problem may lie.
But is it really necessary for a message sent to, say, this mail list which contains all of the text as shown above?
I know that the posting rules for openSUSE lists suggests that the max number of lines in a signature be limited to 4 lines but the above is simply ridiculous.
You are mixing two completely different things: signature and signature ;) The netiquette rule you mentioned applies to signature as in "I put my name at the end of letters I write." And indeed 4 lines max is a reasonable rule. My personal rule would be "as small as possible", in other words, don't include information your readers have no interest in. Speaking of this...
Using openSUSE 12.2 x86_64 KDE 4.8.4 and kernel 3.4.4 on a system with- AMD FX 8-core 3.6/4.2GHz processor 16GB PC14900/1866MHz Quad Channel Corsair "Vengeance" RAM Gigabyte AMD3+ m/board; Gigabyte nVidia GTX550Ti 1GB DDR5 GPU
Most of the information in your own signature has probably very little interest to most of your readers. The signature included in Jeff's post is of the other kind, it is a cryptographic means to guarantee the authenticity of the message (i.e., the message has really been written by Jeff.) Good email clients will not show the block to you, instead they will check the signature automatically and warn you if the check failed. Maybe you need to install or enable the proper plugin for your client to do that. While cryptographic signatures indeed add up to the message length, I think they are very valuable and we do encourage people to use them. Hope this clarifies, -- Jean Delvare Suse L3 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break
It will break.
things since you've already pushed. If that works, it'd be ideal. Otherwise, a "previous commit did xyz (bnc#...)" commit will probably be the cleanest.
Yes, for now, I think this is the best option. In the future, I think we will need a file with changelog fixups and use it when generating the rpm changelog. A simple format commit 1234deadbeef <new changelog> should do. But this is the first issue with the changelog since kernel-source.changes has been removed two years ago, that is not bad at all :). Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Wed, 2012-06-27 at 15:10 +0200, Michal Marek wrote:
On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break
It will break.
That's rather disheartening, because it's already been done and pushed. -Mike -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 6/27/12 9:55 AM, Mike Galbraith wrote:
On Wed, 2012-06-27 at 15:10 +0200, Michal Marek wrote:
On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break
It will break.
That's rather disheartening, because it's already been done and pushed.
It'll break in the manner you already saw -- have two commits instead of the one you intended. Since all of the solutions would have added commits, it's no worse than the other solutions would have been. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP6xTiAAoJEB57S2MheeWyW3YQAKggSopuEHxndLPxaYTLNIWt zimRtj0MN2CFrJS8tLHvgYmXStPPltwYaIhtPDayPhAb7Q6eYDTOWEZpXorlqmV1 vPrsDh/aThoI+8wlJXIc0Ime+XDwOsJRQIjg6/5BvPVbWHs41VAmVy7qiz5anSg0 m6VZmQwtkrQpseiMEzfQzj//0lOrjh+8TDfelo2vnOJ1YFlg1E5NduAZJENpUjn/ 63+bdsInRpEERAg+BXieg2MRfYSW6UEOG42mFV7hzVBgNgFzkUZkqV9qAkpmcR/B 0jA5YXxfCzM2CZ/jq4sIQ3U/TG9inpmGIKa5geQhpnFksz/rVWQqWH0HIONA/Wyc VoCFAbwYi+TnXQNM1VBrS34Ob/98Y4iOLX5jsQe9qoSk5LrspljC9/h+uJKknwYF W3WYYzcxEfS6D/8q9uwfBgxrkBNcR72b4npg6cwtoTw0E+ne09rgFYZ0Frgb2OOB 5DmlY8U6LO4UB/ceV4TlTF8cM0dZ2Qzo5N0igZk4icxLMZxufFIkjXs7Tv/PI0od 0X2mL18ZR94vCj0GcABETXcgwhRlIYYyI6Lf2Ngfp0BYTqM6qUs8ilwX+OA+yzsB BTBCEX9IYkYuoy31Pjbkx8J8b72wXAN2EXvZIk8W1bKdBftbwB3TqJzqThPAGN1S u7SwYZ+OB3nSBWLbeO3N =vOPP -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Wed, 2012-06-27 at 10:12 -0400, Jeff Mahoney wrote:
On 6/27/12 9:55 AM, Mike Galbraith wrote:
On Wed, 2012-06-27 at 15:10 +0200, Michal Marek wrote:
On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break
It will break.
That's rather disheartening, because it's already been done and pushed.
It'll break in the manner you already saw -- have two commits instead of the one you intended. Since all of the solutions would have added commits, it's no worse than the other solutions would have been.
Ok. Sorry for the fuss, I'll watch my changelog verbosity. -Mike -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Mike Galbraith
On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's
On Wed, 2012-06-27 at 15:10 +0200, Michal Marek wrote: the
top commit, I wonder if git commit --amend will work or if it'll break
It will break.
That's rather disheartening, because it's already been done and pushed.
-Mike
Ok, but this created a second commit with a different changelog. But the server won't allow you to overwrite an existing commit. -- Sent from my phone. Please excuse my brevity. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 6/26/12 5:35 PM, Marcus Meissner wrote:
On Tue, Jun 26, 2012 at 11:18:22PM +0200, Jiri Slaby wrote:
On 06/25/2012 01:10 PM, Marcus Meissner wrote:
We are getting lots of bugreports that the current 12.1 kernel update breaks suspend to ram.
bnc#764864 and lots of duplicates.
We should be fine by now...
Jeff, can you submit a new update (maintenancerequest)?
Now that the changelog issue is cleared up, I've issued MR 126330. Thanks everyone! - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP6ys1AAoJEB57S2MheeWyDwIP/3njPId5DH2jtfMnohh9l164 ZRmroSBHEqladMI5mBpmIGArtt4pvIaX8DGnrNVRmwyZRGmflE7LF2Y9uL/V2Qj6 pZZ8E2yPf1kuZr+go+u7zvIi51GJ2RALvq6Rt45Qq/iBlAmlCtu/cJPl6IEXVEpU qUxoNYwtqIy02p5TVyCn43ul9ljrfEURbSi4+SDuVbXAyIeFPzdbSfR5TKpiVWiA fSfLl34TQKWxr71K78meLJuNi95+ojUreI6pS+LGlrvovtNZjsvJQWmyRUcvCtCN P3uPT71q8erHLQBY7M7ICSoOt2+J1loyRZbm5B6Pjjz/0E+YanX8vxfi9g3EMuqk RB/EYaa9Q0peC3FqPVwkTcyYDaPsIq6nyoy7GVpX1GW6kapCBN/0vNB7lQsGXpdm D4WiQJHudHwSqpmRoCpWxAxgfhCNExVgvRGc1gFXJvb3XwLU9NVncGtHCHVi7yMY hizLU5gE2gd9fF9M7TQLwpawATwohXILRHQewt1fnKxBIdJYuMN5wbVXIo9CrPLX RbfAJH/7lNEzK3idsHk+EPmJsAJPHADO2bxSLGQN3yI3fWfPp4zNMC4XLZAPwNUC MnlEpZT0YntWtLK1853GpD3NPrK7lF2fkIRpFMrdOpowYUD6F/Oua+eJAiDGEAdN h/x6D+Mz/xtkjC9wKKol =MX0A -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (7)
-
Basil Chupin
-
Jean Delvare
-
Jeff Mahoney
-
Jiri Slaby
-
Marcus Meissner
-
Michal Marek
-
Mike Galbraith