-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 6/27/12 9:55 AM, Mike Galbraith wrote:
On Wed, 2012-06-27 at 15:10 +0200, Michal Marek wrote:
On 27.6.2012 06:11, Jeff Mahoney wrote:
On 6/27/12 12:07 AM, Mike Galbraith wrote:
Aw poo, no bug reference, and not verbose enough. Yeah, removing the dud patch is the fix. Hm, so to properly document, edit kernel-source.changes and push again, or revert and redo from scratch?
All the options suck. In 12.1, kernel-source.changes isn't used anymore. The changelog is generated from the git log. Since it's the top commit, I wonder if git commit --amend will work or if it'll break
It will break.
That's rather disheartening, because it's already been done and pushed.
It'll break in the manner you already saw -- have two commits instead of the one you intended. Since all of the solutions would have added commits, it's no worse than the other solutions would have been. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJP6xTiAAoJEB57S2MheeWyW3YQAKggSopuEHxndLPxaYTLNIWt zimRtj0MN2CFrJS8tLHvgYmXStPPltwYaIhtPDayPhAb7Q6eYDTOWEZpXorlqmV1 vPrsDh/aThoI+8wlJXIc0Ime+XDwOsJRQIjg6/5BvPVbWHs41VAmVy7qiz5anSg0 m6VZmQwtkrQpseiMEzfQzj//0lOrjh+8TDfelo2vnOJ1YFlg1E5NduAZJENpUjn/ 63+bdsInRpEERAg+BXieg2MRfYSW6UEOG42mFV7hzVBgNgFzkUZkqV9qAkpmcR/B 0jA5YXxfCzM2CZ/jq4sIQ3U/TG9inpmGIKa5geQhpnFksz/rVWQqWH0HIONA/Wyc VoCFAbwYi+TnXQNM1VBrS34Ob/98Y4iOLX5jsQe9qoSk5LrspljC9/h+uJKknwYF W3WYYzcxEfS6D/8q9uwfBgxrkBNcR72b4npg6cwtoTw0E+ne09rgFYZ0Frgb2OOB 5DmlY8U6LO4UB/ceV4TlTF8cM0dZ2Qzo5N0igZk4icxLMZxufFIkjXs7Tv/PI0od 0X2mL18ZR94vCj0GcABETXcgwhRlIYYyI6Lf2Ngfp0BYTqM6qUs8ilwX+OA+yzsB BTBCEX9IYkYuoy31Pjbkx8J8b72wXAN2EXvZIk8W1bKdBftbwB3TqJzqThPAGN1S u7SwYZ+OB3nSBWLbeO3N =vOPP -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org