On 2017-08-25 12:47, Dave Plater wrote:
On 25/08/2017 12:24, Jan Engelhardt wrote:
On Friday 2017-08-25 12:04, Dave Plater wrote:
I'll answer my own question, xlocale.h has been removed in glibc-26 and I suspect can be replaced by locale.h, am I correct?
Any idea which macro contains the glibc version, I've searched high and low. ie. #ifdefined __GLIBC_MAJOR but there only seems to be a __GLIBC_MINOR__
Ideally, there should be a configure-time check for xlocale.h and then you would do
#ifdef HAVE_XLOCALE_H # include
#endif That would be ideal but configure is non standard and there's no configure.in/ac so I've made a spec macro: %define glibc_ver %(ldd --version |grep ldd |cut -d " " -f 4) and apply the patch according to the version. Upstream seemed unsure about using locale.h for lower glibc versions so I'm going with caution. Suppose I could add -D:GLIBC_VERSION= to the build instead.
locale.h is part of POSIX and exists for ages, so go ahead and just use it, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org