On 25 Aug 09:38, Dave Plater wrote:

On 25/08/2017 08:59, Dave Plater wrote:

...

Hi, at least three packages, shotcut, libmlt and it's linked webvfx, that were just accepted into Factory fail to build due to a missing xlocale.h in glibc-devel. Can anybody shed any light on what's happened so I can fix it? Thanks Dave I'll answer my own question, xlocale.h has been removed in glibc-26 and I suspect can be replaced by locale.h, am I correct?

Yes, that's correct. Regards, ismail -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

On 25 Aug 12:04, Dave Plater wrote:

On 25/08/2017 11:56, İsmail Dönmez wrote:

...

On 25 Aug 09:38, Dave Plater wrote:

...

On 25/08/2017 08:59, Dave Plater wrote:

...

Hi, at least three packages, shotcut, libmlt and it's linked webvfx, that were just accepted into Factory fail to build due to a missing xlocale.h in glibc-devel. Can anybody shed any light on what's happened so I can fix it? Thanks Dave I'll answer my own question, xlocale.h has been removed in glibc-26 and I suspect can be replaced by locale.h, am I correct?

Yes, that's correct.

Regards, ismail

Any idea which macro contains the glibc version, I've searched high and low. ie. #ifdefined __GLIBC_MAJOR but there only seems to be a __GLIBC_MINOR__

Even for old glibc including the locale.h is the correct way of doing things so you don't need to check for glibc version. Regards, ismail -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

On 25/08/2017 12:24, Jan Engelhardt wrote:

On Friday 2017-08-25 12:04, Dave Plater wrote:

...

...

...

I'll answer my own question, xlocale.h has been removed in glibc-26 and I suspect can be replaced by locale.h, am I correct?

Any idea which macro contains the glibc version, I've searched high and low. ie. #ifdefined __GLIBC_MAJOR but there only seems to be a __GLIBC_MINOR__

Ideally, there should be a configure-time check for xlocale.h and then you would do

#ifdef HAVE_XLOCALE_H # include #endif

That would be ideal but configure is non standard and there's no configure.in/ac so I've made a spec macro: %define glibc_ver %(ldd --version |grep ldd |cut -d " " -f 4) and apply the patch according to the version. Upstream seemed unsure about using locale.h for lower glibc versions so I'm going with caution. Suppose I could add -D:GLIBC_VERSION= to the build instead. Thanks Dave -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org

On 2017-08-25 12:47, Dave Plater wrote:

On 25/08/2017 12:24, Jan Engelhardt wrote:

...

On Friday 2017-08-25 12:04, Dave Plater wrote:

...

...

...

I'll answer my own question, xlocale.h has been removed in glibc-26 and I suspect can be replaced by locale.h, am I correct?

Any idea which macro contains the glibc version, I've searched high and low. ie. #ifdefined __GLIBC_MAJOR but there only seems to be a __GLIBC_MINOR__

Ideally, there should be a configure-time check for xlocale.h and then you would do

#ifdef HAVE_XLOCALE_H #    include #endif

That would be ideal but configure is non standard and there's no configure.in/ac so I've made a spec macro: %define glibc_ver %(ldd --version |grep ldd |cut -d " " -f 4) and apply the patch according to the version. Upstream seemed unsure about using locale.h for lower glibc versions so I'm going with caution. Suppose I could add -D:GLIBC_VERSION= to the build instead.

locale.h is part of POSIX and exists for ages, so go ahead and just use it, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org

On Aug 25 2017, Dave Plater wrote:

I'll answer my own question, xlocale.h has been removed in glibc-26 and I suspect can be replaced by locale.h, am I correct?

xlocale.h has been obsolete for nearly 10 years, since POSIX.1-2008. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org

On 25/08/2017 09:38, Dave Plater wrote:

On 25/08/2017 08:59, Dave Plater wrote:

...

Hi, at least three packages, shotcut, libmlt and it's linked webvfx, that were just accepted into Factory fail to build due to a missing xlocale.h in glibc-devel. Can anybody shed any light on what's happened so I can fix it? Thanks Dave I'll answer my own question, xlocale.h has been removed in glibc-26 and I suspect can be replaced by locale.h, am I correct? Thanks Dave P

Thanks for all the help, I wanted to be in sync with upstream which also has an apple build. I ended up with: #if defined(__GLIBC__) || defined(__APPLE__) || (__FreeBSD_version >= 900506) +#if __GLIBC_MINOR__ >= 26 && !defined(__APPLE__) +#include +#else #include +#endif #else Which made upstream happy. This fixed libmlt and webvfx builds but shotcut is still in a failed state although my home:plater shotcut started building for Factory again. Thanks again Dave P -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org

On Montag, 28. August 2017 13:58:24 CEST Dominique Leuenberger / DimStar wrote:

On Mon, 2017-08-28 at 13:43 +0200, Dave Plater wrote:

...

This fixed libmlt and webvfx builds but shotcut is still in a failed state although my home:plater shotcut started building for Factory again. Thanks again Dave P

I triggered a rebuild of openSUSE:Factory/shotcut - this should hopefully also resolve this issue now (as it builds against the fixed libmlt you submitted over the weekend)

Can someone also trigger a rebuild of https://build.opensuse.org/package/show/ openSUSE:Factory:ARM/libxslt ? libxslts headers include xlocale.h when it was available a build time, so every package trying to build against libxslt currently fails (e.g. kdoctools). Kind regards, Stefan-- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org