Hi, On 2010-05-24 19:16:47 +0800, JF Ding wrote:
As we using obs/osc in Moblin/MeeGo development, we have maintained several internal used plugins to support new commands for special usage. One of the most used one, 'mobsr' (stands for moblin-send-request), is a wrapper to the built-in 'sr' command and with extra checking and function to send mail to mailing list. We consider the sendmail feature can be a generic enhancement to original 'sr' command, so I am trying to rewrite the code based on upstream osc git. Hmm I'm not quite sure if this functionality should be implemented in osc itself. It rather should be implemented in the api/backend. Then you could specify for each project something like a mailinglist attribute or something else and hermes (or another notification delivery tool) can send the notification. This way you would also get notifications if a user uses webui.
I just had a quick glance at your patch and there are some issues IMHO: * with the current implementation you would always send emails to the the mailinglist regardless of the project etc. (it would be better if you could specify a mailinglist on a per project basis) * in get_source_file_content(): it's probably better to pass in the "src_rev" attribute from the request instead of using the latest upstream revision. (The same applies to the meta_get_filelist() call) Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org