Am Dienstag, 25. Mai 2010, 08:51:09 schrieb JF Ding:

Marcus, thanks for your reviewing. Yes, it will be perfect if the mailing list feature is implemented at obs server side.

Actually it is. But you need to setup and run hermes. This is unfortunatly not yet in a shape that we make it part of our OBS release. But AFAIK Klaas is working on improving it so that we can make it part of it. Klaas, what is missing here ? Can others help ? Hermes wiki page: http://en.opensuse.org/Hermes bye adrian

But the current osc method is probably the simplest to do this work, and can be delivered to end user easily, without upgrade and configure ther server components.

And we can consider the mailinglist support per apiurl is the first step, and it can meet most of requirements. Mailing list per project can also be implemented in osc, with extra project attribute. If the need for it is popular, I'll try to add it later.

The "src_rev" problem was fixed in one new commit, thanks for your reminding.

- JF Ding

On Tue, May 25, 2010 at 4:49 AM, Marcus Hüwe wrote:

...

Hi,

On 2010-05-24 19:16:47 +0800, JF Ding wrote:

...

As we using obs/osc in Moblin/MeeGo development, we have maintained several internal used plugins to support new commands for special usage. One of the most used one, 'mobsr' (stands for moblin-send-request), is a wrapper to the built-in 'sr' command and with extra checking and function to send mail to mailing list. We consider the sendmail feature can be a generic enhancement to original 'sr' command, so I am trying to rewrite the code based on upstream osc git. Hmm I'm not quite sure if this functionality should be implemented in osc itself. It rather should be implemented in the api/backend. Then you could specify for each project something like a mailinglist attribute or something else and hermes (or another notification delivery tool) can send the notification. This way you would also get notifications if a user uses webui.

I just had a quick glance at your patch and there are some issues IMHO: * with the current implementation you would always send emails to the the mailinglist regardless of the project etc. (it would be better if you could specify a mailinglist on a per project basis) * in get_source_file_content(): it's probably better to pass in the "src_rev" attribute from the request instead of using the latest upstream revision. (The same applies to the meta_get_filelist() call)

Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

-- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de

On 2010-05-25 18:02:46 +0800, JF Ding wrote:

Hermes is really a great message aggregation/dispatching system. As my understanding, with it being deployed together with obs, we can make osc to access hermes' REST api to trigger server side sending mails when 'sr', if need to implement the same requirement of my commits. Right?

No this would completely happen on the server side. osc or other clients would just issue the initial request (like creating a new sr) and the the api/backend will trigger hermes to send out the notifications. Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Hi,

...

...

Hermes is really a great message aggregation/dispatching system. As my understanding, with it being deployed together with obs, we can make osc to access hermes' REST api to trigger server side sending mails when 'sr', if need to implement the same requirement of my commits. Right?

No this would completely happen on the server side. osc or other clients would just issue the initial request (like creating a new sr) and the the api/backend will trigger hermes to send out the notifications.

I means, the trigger of Hermes "storage" can be from both obs webui/api, and osc the client side directly thru REST(maybe not in origin design, but we can do it). Right? Thats correct, it could. But it should only from server side.

If leaving all configurable in server side (obs and Hermes), osc user will lost the flexibility to control the mails. Sometime maybe we do not want to send notifications to mailing list. (maybe webui for Hermes can close it temporarily, but it's not convenient like command line options) What kind of control over the mails are you thinking of?

I have tried openSUSE's Hermes pages, there are only support for notification mails to request related users by now. So if we want to send to mailing list, we must register a fake user with mail address as the mailing list and add it to listened projects, as a workaround? Yes, subscribe hermes@opensuse.org or allow him to post without being subscribed.

Klaas -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

On Tue, May 25, 2010 at 8:11 PM, Andreas Jaeger wrote:

On Tuesday 25 May 2010 13:14:12 Marcus Hüwe wrote:

...

On 2010-05-25 18:02:46 +0800, JF Ding wrote:

...

 Hermes is really a great message aggregation/dispatching system. As

my understanding, with it being deployed together with obs, we can make osc to access hermes' REST api to trigger server side sending mails when 'sr', if need to implement the same requirement of my commits. Right?

No this would completely happen on the server side. osc or other clients would just issue the initial request (like creating a new sr) and the the api/backend will trigger hermes to send out the notifications.

The advantage of using hermes is that it will work also with other clients besides osc, e.g. with submitrequests in the WebUI...

Andreas

Agree. Hermes will be very helpful if being deployed in our meego obs server I feel. As for osc, do you think it is useful for osc users to merge my commits for "local smtp sending mail in sr" ? Any advice welcome! - jf.ding -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org