[Bug 1234583] New: VUL-0: CVE-2024-45337: chezmoi: golang.org/x/crypto/ssh: Misuse of ServerConfig.PublicKeyCallback may cause authorization bypass in golang.org/x/crypto
https://bugzilla.suse.com/show_bug.cgi?id=1234583 Bug ID: 1234583 Summary: VUL-0: CVE-2024-45337: chezmoi: golang.org/x/crypto/ssh: Misuse of ServerConfig.PublicKeyCallback may cause authorization bypass in golang.org/x/crypto Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.5 Hardware: Other URL: https://smash.suse.de/issue/432234/ OS: Other Status: NEW Whiteboard: CVSSv3.1:SUSE:CVE-2024-45337:8.1:(AV:N/AC:H/PR:N/UI:N/ S:U/C:H/I:H/A:H) Severity: Normal Priority: P5 - None Component: Security Assignee: filippo.bonazzi@suse.com Reporter: andrea.mattiazzo@suse.com QA Contact: security-team@suse.de Blocks: 1234482 Target Milestone: --- Found By: --- Blocker: --- Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass. The documentation for ServerConfig.PublicKeyCallback says that "A call to this function does not guarantee that the key offered is in fact used to authenticate." Specifically, the SSH protocol allows clients to inquire about whether a public key is acceptable before proving control of the corresponding private key. PublicKeyCallback may be called with multiple keys, and the order in which the keys were provided cannot be used to infer which key the client successfully authenticated with, if any. Some applications, which store the key(s) passed to PublicKeyCallback (or derived information) and make security relevant determinations based on it once the connection is established, may make incorrect assumptions. For example, an attacker may send public keys A and B, and then authenticate with A. PublicKeyCallback would be called only twice, first with A and then with B. A vulnerable application may then make authorization decisions based on key B for which the attacker does not actually control the private key. Since this API is widely misused, as a partial mitigation golang.org/x/cry...@v0.31.0 enforces the property that, when successfully authenticating via public key, the last key passed to ServerConfig.PublicKeyCallback will be the key used to authenticate the connection. PublicKeyCallback will now be called multiple times with the same key, if necessary. Note that the client may still not control the last key passed to PublicKeyCallback if the connection is then authenticated with a different method, such as PasswordCallback, KeyboardInteractiveCallback, or NoClientAuth. Users should be using the Extensions field of the Permissions return value from the various authentication callbacks to record data associated with the authentication attempt instead of referencing external state. Once the connection is established the state corresponding to the successful authentication attempt can be retrieved via the ServerConn.Permissions field. Note that some third-party libraries misuse the Permissions type by sharing it across authentication attempts; users of third-party libraries should refer to the relevant projects for guidance. References: http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-45337 https://www.cve.org/CVERecord?id=CVE-2024-45337 https://github.com/golang/crypto/commit/b4f1988a35dee11ec3e05d6bf3e90b695fbd... https://go.dev/cl/635315 https://go.dev/issue/70779 https://groups.google.com/g/golang-announce/c/-nPEi39gI4Q/m/cGVPJCqdAQAJ https://pkg.go.dev/vuln/GO-2024-3321 http://www.openwall.com/lists/oss-security/2024/12/11/2 https://bugzilla.redhat.com/show_bug.cgi?id=2331720 https://github.com/CVEProject/cvelistV5/blob/main//cves/2024/45xxx/CVE-2024-... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 https://bugzilla.suse.com/show_bug.cgi?id=1234583#c1 --- Comment #1 from Andrea Mattiazzo <andrea.mattiazzo@suse.com> --- The packages below are or contain embedded packages that are vulnerable to CVE-2024-45337: - openSUSE:Backports:SLE-15-SP5/chezmoi contains embedded package: golang.org/x/crypto/ssh (0.5.0) - openSUSE:Backports:SLE-15-SP5:Update/chezmoi contains embedded package: golang.org/x/crypto/ssh (0.5.0) - openSUSE:Backports:SLE-15-SP6/chezmoi contains embedded package: golang.org/x/crypto/ssh (0.13.0) - openSUSE:Backports:SLE-15-SP6:Update/chezmoi contains embedded package: golang.org/x/crypto/ssh (0.13.0) - openSUSE:Factory/chezmoi contains embedded package: golang.org/x/crypto/ssh (0.29.0) Please consider version bumping or patching the affected dependencies. The listed codestreams are affected. All other codestreams should not be affected, but feel free to double-check. This is a auto-generated message, please reach out to the reporter directly if you think this is incorrect. No bug-owner found for these packages, if the assignation is not correct feel free to re-assign. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 Filippo Bonazzi <filippo.bonazzi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|filippo.bonazzi@suse.com |mlin@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 https://bugzilla.suse.com/show_bug.cgi?id=1234583#c2 Filippo Bonazzi <filippo.bonazzi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |filippo.bonazzi@suse.com, | |mlin@suse.com Flags| |needinfo?(mlin@suse.com) --- Comment #2 from Filippo Bonazzi <filippo.bonazzi@suse.com> --- Assigning to Max Lin as he submitted chezmoi to Leap 15.x and Leap 16. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 SMASH SMASH <smash_bz@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 https://bugzilla.suse.com/show_bug.cgi?id=1234583#c3 Max Lin <mlin@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mlin@suse.com |security-team@suse.de Flags|needinfo?(mlin@suse.com) | --- Comment #3 from Max Lin <mlin@suse.com> --- It must be a mis-understanding, the request is created by a script triggered by release team, we don't set individual package maintainer on Leap(or the previous regular release version) for each package, we hopes package maintainer in openSUSE to take care of package across different openSUSE products(Tumbleweed, Leap, and so on), as it is before the package maintainer is inherited from devel project, therefore the script has opened a review to devel-project/devel-package to get maintainer's ack - willing to maintain the package for inclusion into Leap, for any reason maintainer don't like to maintain that package in Leap then package maintainer can decline the request. It has explaining in the description of SR. The chezmoi SR was reviewed by package maintainer[1][2] according to the request history. Release team has no capability to maintain thousands of package. If the description of SR is not clear then we can fix it. If the approvement of submission is a mistake we can remove the package from Leap 16.0(Not likely for 15.x since it was out). [1] https://build.opensuse.org/request/show/1209569 [2] https://build.opensuse.org/request/show/1011367 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 https://bugzilla.suse.com/show_bug.cgi?id=1234583#c4 Filippo Bonazzi <filippo.bonazzi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #4 from Filippo Bonazzi <filippo.bonazzi@suse.com> --- It was not clear to me that approving a review of a SR of chezmoi to Leap, done by somebody else, was an agreement for me to take on maintenance of chezmoi in Leap. Now that I know it, I will most likely ignore or decline such requests in the future. Now to handle this bug: if I can simply submit a Chezmoi version update to latest in the affected codestreams, I will do that. If a version update is not acceptable, I will submit a request for package removal. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 https://bugzilla.suse.com/show_bug.cgi?id=1234583#c5 --- Comment #5 from Max Lin <mlin@suse.com> --- (In reply to Filippo Bonazzi from comment #4)
It was not clear to me that approving a review of a SR of chezmoi to Leap, done by somebody else, was an agreement for me to take on maintenance of chezmoi in Leap.
Now that I know it, I will most likely ignore or decline such requests in the future.
If package maintainer don't want to take on maintenance of the package to Leap, in the meanwhile submitter or somebody else volunteering to maintain that package in Leap, we can manage it by set an individual package maintainer for that package in Leap project, otherwise, package in Leap doesn't have an individual package maintainer. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1234583 https://bugzilla.suse.com/show_bug.cgi?id=1234583#c6 Andrea Mattiazzo <andrea.mattiazzo@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |INVALID --- Comment #6 from Andrea Mattiazzo <andrea.mattiazzo@suse.com> --- I don't see any call to PublicKeyCallback inside chezmoi sources, so it is not affected and the vendored library doesn't require a bump. Closing the bug as INVALID. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com