http://bugzilla.novell.com/show_bug.cgi?id=535926
Summary: openvas-client-2.0.4-1.3: bad call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: ---
I just had a look at factory package openvas-client-2.0.4-1.3
For source code file openvas-client-2.0.4/libnessus/rand.c around line 60, function nessus_init_random is the following code
if ((fd = open(EGD_PATH, O_RDWR)) >= 0)
but the matching call to close is
close(s);
which looks wrong. Maybe
close( fd);
would be better.
http://bugzilla.novell.com/show_bug.cgi?id=535926
Marcus Meissner meissner@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |nadvornik@novell.com |ovo.novell.com |
http://bugzilla.novell.com/show_bug.cgi?id=535926
User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=535926#c1
--- Comment #1 from Richard Guenther rguenther@novell.com 2009-10-17 08:55:19 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream.
Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM.
Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime.
http://bugzilla.novell.com/show_bug.cgi?id=535926 http://bugzilla.novell.com/show_bug.cgi?id=535926#c2
Vladimir Nadvornik nadvornik@suse.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #2 from Vladimir Nadvornik nadvornik@suse.com --- wontfix