New subject: [Bug 502531] bsd-games-2.17-81.44: undefined code

9 May 2009

http://bugzilla.novell.com/show_bug.cgi?id=502531

           Summary: bsd-games-2.17-81.44: undefined code
    Classification: openSUSE
           Product: openSUSE 11.2
           Version: Factory
          Platform: All
        OS/Version: openSUSE 11.1
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: Other
        AssignedTo: bnc-team-screening(a)forge.provo.novell.com
        ReportedBy: dcb314(a)hotmail.com
         QAContact: qa(a)suse.de
          Found By: ---

I just tried to build Factory package bsd-games-2.17-81.44
and the build said

monop/cards.c:138: warning: operation on "dp->last_card" may be undefined

The source code is

        dp->last_card = ++(dp->last_card) % dp->num_cards;

I agree with the compiler. Better code would be

        dp->last_card = (dp->last_card + 1) % dp->num_cards;

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 502531] New: bsd-games-2.17-81.44: undefined code