http://bugzilla.novell.com/show_bug.cgi?id=544454
Summary: openvas-client-2.0.4-1.6: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: ---
I just had a look at factory package openvas-client-2.0.4-1.6 source code file openvas-client-2.0.4/nessus/read_target_file.c function target_file_to_list local variable fd
I notice the following code
HANDLE fd = open(filename, O_RDONLY);
but I fail to find a matching call to close. This looks like a resource leak to me. Suggest add call to close near the end of the function.
http://bugzilla.novell.com/show_bug.cgi?id=544454
Marcus Meissner meissner@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |nadvornik@novell.com |ovo.novell.com |
http://bugzilla.novell.com/show_bug.cgi?id=544454
User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=544454#c1
--- Comment #1 from Richard Guenther rguenther@novell.com 2009-10-17 08:56:12 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream.
Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM.
Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime.
http://bugzilla.novell.com/show_bug.cgi?id=544454 http://bugzilla.novell.com/show_bug.cgi?id=544454#c2
Vladimir Nadvornik nadvornik@suse.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #2 from Vladimir Nadvornik nadvornik@suse.com --- wontfix