http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c1 --- Comment #1 from Ancor Gonzalez Sosa --- According to control.xml, 10 GiB is the minimum acceptable size to propose for / when snapshots are enabled (https://github.com/yast/skelcd-control-openSUSE/blob/SLE-15-GA/control/contr...)

5 GiB 100

That is, 5 GiB of minimum is no snapshots are enabled and 10 GiB if they are enabled. If those 10 GiBs are in fact not enough, the settings for the corresponding product/role must be adjusted in skelcd. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 Libor Pechacek changed: What |Removed |Added ---------------------------------------------------------------------------- CC|lpechacek@suse.com | -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c3 Ludwig Nussel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Ludwig Nussel --- closed wontfix for 15.0 proposal parameters need to be tuned for 15.1 again -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c17 Stefan Schubert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schubi@suse.com Assignee|yast2-maintainers@suse.de |rbrown@suse.com --- Comment #17 from Stefan Schubert --- (In reply to Ludwig Nussel from comment #16)

(In reply to Richard Brown from comment #14)

...

Changing assignee - Ludwig removed all my latest changes to the Leap control file so it's probably best he fixed this

huh? I just changed some wordings while adding a custom role to fix openQA breakage as nobody else bothered to do that. I didn't touch partitioning or anything else.

Who adjusts that stuff for SLE? That person please also take care of Leap. I have no clue about the knobs and handles there.

So, back to Richard :-) -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c24 Max Lin changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rbrown@suse.com) --- Comment #24 from Max Lin --- I thought the change should about home partition only, but the minimal partition size requirement also changed according to https://build.opensuse.org/request/show/651142 , that means we have to increasing all HDDSIZEGB to 40 on openQA otherwise the installer will not proposing any default partition setup, is it intentional? -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c26 --- Comment #26 from Ancor Gonzalez Sosa --- I don't think the adjustments done to the volumes match with the original intention. See this extract of the root and home volumes done in the already mentioned SR https://build.opensuse.org/request/show/651339. <volume> / btrfs 10 GiB 5 GiB unlimited 300 </volume> <volume> /home xfs 40 GiB 10 GiB unlimited <!-- if this volume is disabled we want "/" to increase --> / / / / </volume> According to that, if a separate home is not proposed, the desired size for root is 50GiB (specified via fallback_for_desired_size). And that amount is then multiplied by 4 (or increased by a 300% to be more correct) because of the snapshots and the value of snapshots_percentage. Likely that was not the intended behavior. I guess fallback_for_desired_size should not be set (if the intention is to reduce the requirements). -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c29 --- Comment #29 from Jiri Srain --- The question is not whether or not to create a separate home partition if the disk has similar size as yours - in this case, it will be proposed (and we may discuss which portion of the disk it should take - but here you will clearly never please everyone). The discussion is how the default proposal should behave if the disk is small - and you need to make some compromises because the standard set-up would not fit. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c31 --- Comment #31 from Ancor Gonzalez Sosa --- Let me share a tip for anyone playing with the control file settings to fine-tune the partitioning (Richard, in this case). If you have a local checkout of the yast-storage-ng repository[1], you can execute this to see how the Guided Setup (and its initial attempt) works in any scenario based on your local modified control file (assuming you are executing this from the root path of your local copy of the repo): Y2DIR=src/ /sbin/yast2 proposal_testing a_system_description.yml your_control.xml In the test/data/devicegraphs directory of the repo you have many examples of systems with different disks (including sizes, types and content of such disks). And creating a new one is quite simple following the same Yaml syntax. So you can execute something like this: Y2DIR=src/ /sbin/yast2 proposal_testing test/data/devicegraphs/empty_disks.yml your_control.xml Way quicker and more flexible than testing the changes in a real installation [1] https://github.com/yast/yast-storage-ng/ -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c33 Richard Brown changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED Flags|needinfo?(rbrown@suse.com) | --- Comment #33 from Richard Brown --- Code fixed, tests passing, closing this even though it hasn't been fully merged yet (looks like it's blocked by yast2 lan in staging M) to answer some of the concerns

1. Will /home get formatted on a fresh installation?

Yes, just as /var does, or /opt, or /usr/local, and /etc, and all the other locations on the filesystem which does have user-supplied information. We've never optimised for 'reinstallation'. We have perfectly good in place upgrade options, and any user doing an installation should always, always backup all of the above locations and any other which include data they might want post-installation. That said, it's a simple tick box in the guided installer to have a separate /home partition for those that prefer the old behaviour.

2. Do we have a reasonable GUI to remove less important snapshots in out-of-disk situation? I mean something that would show what is archived by which snapshot and how much space each snapshot blocks.

YaST2 snapper does all of the above besides "how much space each snapshot blocks", because the nature of CoW prevents it. Think of it this way: deleting one snapshot that currently blocks a lot of space, doesn't necessarily reclaim all that space, because when other (previously smaller, as CoW snapshots only retain diffs) snapshot now references all the data previously 'owned' by the old 'larger' snapshot. We have advanced built-in, automatic, deletion of snapshots based space in use. It needs a certain amount of space for the process to work properly and reliably. With these new defaults I expect the topic of snapshot space in use will be far less of a concern to far fewer people. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c35 --- Comment #35 from Josef Reidinger --- (In reply to Ancor Gonzalez Sosa from comment #34)

(In reply to Petr Mladek from comment #32)

...

I am in the scared more back again. OK, let me ask:

1. Will /home get formatted on a fresh installation?

As I read your question, you seem to expect the installer to recognize preexisting /home partitions (from a previous installation) and then either reuse such partition as /home for the new installation or at least avoid to delete such partition.

As far as I know, the installer has never done that as part of the automated partitioning proposal.

By default we don't inspect the content of the existing Linux partitions trying to guess their former role (neither to keep them or to reuse them). We just try to make enough space for the new system by resizing or deleting the existing Windows or Linux partitions, that's all we do and, as far as I know, all what we have ever done. There is no specific logic (and has never been, as far as I'm aware) to preserve your pre-existing /home. The existing Linux partitions will be deleted if we need the disk space they are using, no matter if they are a former "/" or a former "/home", "/var" or whatever.

I think that maybe question is related to "import mount points" option that allows to read partitioning and I think it is less aggressive in cleaning. But it is not done automatic. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 Jeff Mahoney changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jeffm@suse.com) | -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.suse.com/show_bug.cgi?id=1093372 http://bugzilla.suse.com/show_bug.cgi?id=1093372#c39 --- Comment #39 from Ludwig Nussel --- it's certainly not optimized for random home user desktops who have their data in the cloud nowadays anyways. If you know what you are doing you are not going to like the proposal anyways. If you are in a corporate environment you will have central authentication and home dir backups. If you use a VM you don't care about /home either. So for the sake of simplicity the installer will propose the least complicated setup. -- You are receiving this mail because: You are on the CC list for the bug.