https://bugzilla.novell.com/show_bug.cgi?id=328048#c18
--- Comment #18 from Jörg Kreß
if ("</stream>") { if (security_patches_done) { if (recommended_patches_done || !packages_included) { if (restart_included) { dialog ("you need to restart"); gtk_main_quit (); } else { dialog ("I'm done"); gtk_main_quit (); } } else { recommended_patches_done = TRUE; /* go back to main loop */ } } else { if (!recommended_included && !packages_included) { if (restart_included) { dialog ("you need to restart"); gtk_main_quit (); } else { dialog ("I'm done"); gtk_main_quit (); } } /* no dialog here */ } }
So not all cases present a dialog.
In _this_ very case it is perfectly fine because the else would represent another /* go back to main loop */ as we have still some recommended and/or packages to do. The "security_patches_done" was set TRUE before which makes it not very concise. BUT: Stepping through it again revealed that the mistake was somewhere else: the cases in which we have packages but no recommended was not included (stupid me). changing line 3 if (recommended_patches_done || !packages_included) to if (recommended_patches_done || !packages_included || (packages_included && !recommended_included)) should do the trick. I stepped through it and now all possible 6 permutations are included to present one of the success windows. Added code. FYI: If your are confused about the variables, we changed the wording in the UI late in development, but still had 3 classes so I kept the code: code: UI (default updates included): security mandatory updates (security & recommended patches) recommended additional updates (optional patches) packages additional updates (if user includes packages) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.