https://bugzilla.novell.com/show_bug.cgi?id=328048 JP Rosevear changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Blocker -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c2 Stephen Holmes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sholmes@novell.com --- Comment #2 from Stephen Holmes 2007-09-25 14:25:26 MST --- Scenario in which defect was seen. - Installed openSUSE 10.1RC1 (without updates during base install) - Zypper tray icon shows (orange sun) icon, when opened, it shows... 0 mandatory updates Include 1543 additional updates - Click on install. Progress bar moves for about 15-20 Seconds, then freezes zypper.log shows... 2007-09-25 14:21:56 <2> frodo(20783) [zypp] ResolverContext.cc(addError):1255 2007-09-25 14:21:56 <0> frodo(20783) [zypp] Resolver.cc(resolveDependencies):1148 Pend 0 / Cmpl 0 / Prun 0 / Defr 0 / Invl 1 2007-09-25 14:21:56 <1> frodo(20783) [zypp] Resolver.cc(resolvePool):1372 !!! Have NO solution !!! 2007-09-25 14:21:56 <1> frodo(20783) [zypp] Resolver_problems.cc(problems):350 Resolver::problems() 2007-09-25 14:21:56 <1> frodo(20783) [zypp] Resolver_problems.cc(problems):359 1 invalid queues 2007-09-25 14:22:07 <1> frodo(20783) [zypp] Resolver_problems.cc(problems):411 Problem: ResolverInfo gstreamer010-plugins-good-0.10.6-39.i586[http://download.opensuse.org/repositories/openSUSE:10.3/standard/] Error!>>There are no installable providers of gstreamer010 == 0.10.13 for gstreamer010-plugins-good-0.10.6-39.i586[http://download.opensuse.org/repositories/openSUSE:10.3/standard/]<<, Trigger: none 2007-09-25 14:22:07 <1> frodo(20783) [zypp] PathInfo.cc(_Log_Result):295 recursive_rmdir /var/tmp/zypp.EeTPaZ 2007-09-25 14:22:07 <0> frodo(20783) [zypp] TmpPath.cc(~Impl):78 TmpPath cleaned up /var/tmp/zypp.EeTPaZ{d 0700 0/0} 2007-09-25 14:22:07 <1> frodo(20783) [zypp] RpmDb.cc(closeDatabase):772 Calling closeDatabase: RpmDb[V4(X--)V3(---): '(/)/var/lib/rpm'] 2007-09-25 14:22:07 <1> frodo(20783) [zypp] librpmDb.cc(blockAccess):326 Block access 2007-09-25 14:22:07 <1> frodo(20783) [zypp] RpmDb.cc(closeDatabase):804 closeDatabase: RpmDb[NO_INIT] 2007-09-25 14:22:07 <1> frodo(20783) [zypp] TargetImpl.cc(~TargetImpl):288 Targets closed 2007-09-25 14:22:07 <1> frodo(20783) [zypp] RpmDb.cc(~RpmDb):302 ~RpmDb() 2007-09-25 14:22:07 <1> frodo(20783) [zypp] RpmDb.cc(~RpmDb):307 ~RpmDb() end 2007-09-25 14:22:08 <1> frodo(20783) [zypp] ZYppFactory.cc(unLockFile):139 unlocked 2007-09-25 14:22:08 <1> frodo(20783) [zypp] ZYppFactory.cc(~ZYppGlobalLock):81 Cleaning lock file. (20783) 2007-09-25 14:22:08 <1> frodo(20783) [zypp] PathInfo.cc(_Log_Result):295 unlink /var/run/zypp.pid 2007-09-25 14:22:08 <1> frodo(20783) [zypp] ZYppFactory.cc(~ZYppGlobalLock):83 Lockfile cleaned. (20783) 2007-09-25 14:22:08 <0> frodo(20783) [zypper] zypper-sources.cc(load_target_resolvables):1103 1974 resolvables read -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c4 --- Comment #4 from Stephen Holmes 2007-09-25 14:45:21 MST --- Should have also added that running zypper lu from a terminal shows 0 updates available, whereas the gui shows ~1500 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c6 --- Comment #6 from JP Rosevear 2007-09-25 15:05:05 MST --- Failed here with RC1->factory on x86_64 just now: 2007-09-25 16:56:10 <1> rook(8936) [zypp] librpmDb.cc(blockAccess):326 Block access 2007-09-25 16:56:10 <1> rook(8936) [zypp] RpmDb.cc(closeDatabase):804 closeDatabase: RpmDb[NO_INIT] 2007-09-25 16:56:10 <1> rook(8936) [zypp] TargetImpl.cc(~TargetImpl):288 Targets closed 2007-09-25 16:56:10 <1> rook(8936) [zypp] RpmDb.cc(~RpmDb):302 ~RpmDb() 2007-09-25 16:56:10 <1> rook(8936) [zypp] RpmDb.cc(~RpmDb):307 ~RpmDb() end 2007-09-25 16:56:10 <0> rook(8936) [zypp] MediaHandler.cc(release):706 Request to release media - not attached; eject 0 2007-09-25 16:56:10 <1> rook(8936) [zypp] MediaAccess.cc(close):208 Close: http(http://download.opensuse.org/distribution/SL-OSS-factory/inst-source not attached; localRoot "") (OK) 2007-09-25 16:56:10 <0> rook(8936) [zypp] MediaHandler.cc(release):706 Request to release media - not attached; eject 0 2007-09-25 16:56:10 <0> rook(8936) [zypp] MediaHandler.cc(removeAttachPoint):178 MediaHandler - checking if to remove attach point 2007-09-25 16:56:11 <1> rook(8936) [zypp] ZYppFactory.cc(unLockFile):139 unlocked 2007-09-25 16:56:11 <1> rook(8936) [zypp] ZYppFactory.cc(~ZYppGlobalLock):81 Cleaning lock file. (8936) 2007-09-25 16:56:11 <1> rook(8936) [zypp] PathInfo.cc(_Log_Result):295 unlink /var/run/zypp.pid 2007-09-25 16:56:11 <1> rook(8936) [zypp] ZYppFactory.cc(~ZYppGlobalLock):83 Lockfile cleaned. (8936) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c8 Federico Mena Quintero changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |federico@novell.com --- Comment #8 from Federico Mena Quintero 2007-09-25 15:34:44 MST --- Updater-zypper-gui may keep on running if you close its status dialogs with something other than the "OK" button --- the code has this pattern: if (gtk_dialog_run (dialog) == GTK_RESPONSE_OK) gtk_main_quit(); /* else remain in the main loop */ If the intention is to exit the program as soon as the dialog is closed, regardless of *how* it is closed, then simply remove the "if" and do gtk_main_quit() unconditionally. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c10 Stephan Kulow changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com Severity|Blocker |Critical --- Comment #10 from Stephan Kulow 2007-09-26 00:37:20 MST --- as a factory upgrade will not happen for a 10.3 user before he installed his first patches, I don't think this is a blocker. BTW: I wonder why it updates packages by default. But there won't packages updates in the default repositories either, so it shouldn't matter. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c12 --- Comment #12 from Nikolay Paskov 2007-09-26 01:23:19 MST --- JPR is right the errors must be reported to the user as well as unresolvable dependencies and solutions to chose from. The current version of the GUI doesn't inform you when an update failed due to unresolvable dependencies and ends up without notification. Next time when you check for updates of course it shows you the same amount of uninstalled updates. Usually I'm using the command line to update because I can see also the progress but for the regular novice user it will be flustered. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c14 --- Comment #14 from Federico Mena Quintero 2007-09-26 11:41:23 MST --- Created an attachment (id=174928) --> (https://bugzilla.novell.com/attachment.cgi?id=174928) /exit-after-helper-dies.diff This is the patch I sent to Josh for review. JPR says it works fine for him, but I'm not 100% sure that the code flow is correct in parse_output() --- should the applet *always* present an "updates installed" informational dialog at the end and exit? Or just in some situations? Right now there are different dialogs for "a restart is needed" and the normal case; but this last one is not always invoked. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c16 --- Comment #16 from Federico Mena Quintero 2007-09-26 13:16:01 MST --- (In reply to comment #15 from Joerg Kress)

The Patch from Federico works for me too. It will be in the update that also brings relief to the security guys about the /tmp issue.

Excellent, thanks!

I look at the code flow again, but the success dialog should be shown when everything worked fine except there have been updates which require restart which will show the restart dialog.

Hmm, ok. From looking at the code, it has this pattern: if ("</stream>") { if (security_patches_done) { if (recommended_patches_done || !packages_included) { if (restart_included) { dialog ("you need to restart"); gtk_main_quit (); } else { dialog ("I'm done"); gtk_main_quit (); } } else { recommended_patches_done = TRUE; /* go back to main loop */ } } else { if (!recommended_included && !packages_included) { if (restart_included) { dialog ("you need to restart"); gtk_main_quit (); } else { dialog ("I'm done"); gtk_main_quit (); } } /* no dialog here */ } } So not all cases present a dialog. Also, the code only looks for "<stream>" and "</stream>", but doesn't seem to do any real parsing of the contents... does it need to? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=328048#c18 --- Comment #18 from Jörg Kreß 2007-09-27 03:18:57 MST --- (In reply to comment #16 from Federico Mena Quintero)

if ("</stream>") { if (security_patches_done) { if (recommended_patches_done || !packages_included) { if (restart_included) { dialog ("you need to restart"); gtk_main_quit (); } else { dialog ("I'm done"); gtk_main_quit (); } } else { recommended_patches_done = TRUE; /* go back to main loop */ } } else { if (!recommended_included && !packages_included) { if (restart_included) { dialog ("you need to restart"); gtk_main_quit (); } else { dialog ("I'm done"); gtk_main_quit (); } } /* no dialog here */ } }

So not all cases present a dialog.

In _this_ very case it is perfectly fine because the else would represent another /* go back to main loop */ as we have still some recommended and/or packages to do. The "security_patches_done" was set TRUE before which makes it not very concise. BUT: Stepping through it again revealed that the mistake was somewhere else: the cases in which we have packages but no recommended was not included (stupid me). changing line 3 if (recommended_patches_done || !packages_included) to if (recommended_patches_done || !packages_included || (packages_included && !recommended_included)) should do the trick. I stepped through it and now all possible 6 permutations are included to present one of the success windows. Added code. FYI: If your are confused about the variables, we changed the wording in the UI late in development, but still had 3 classes so I kept the code: code: UI (default updates included): security mandatory updates (security & recommended patches) recommended additional updates (optional patches) packages additional updates (if user includes packages) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.