https://bugzilla.novell.com/show_bug.cgi?id=801920
https://bugzilla.novell.com/show_bug.cgi?id=801920#c16
--- Comment #16 from Robert Schweikert 2013-04-19 16:46:38 UTC ---
The filename for the config file should be stored in the KIWIXMLPreferenceData
class and should be returned by this class rather than by KIWIXML. The method
name should indicate that a file name is being returned.
The expected location of the package manager config file needs to be
documented.
The warning about ignoring the package manager configuration file should be in
the XMLValidator and not in the PackageManager object as this is an XML
inconsistency rather than a PackagManager issue.
There is an issue in the case where the preferences from the user description
get merged with the boot image description. In this case the name of the
package manager config file will be defined, but the boot image description
will not contain the file, thus "tie %cfgini, 'Config::IniFiles', ...." will
probably fail in some weird way. There is no protection against this case.
Rather than __generate... you want to implement a __getCmdArgsFromCfgFile
method that delivers the arguments as a string. The string usage is more
flexible as we can use it in concatenation.
We also recently changed our naming convention. methods intended for
overwriting should start with a v_. However, for now I do not think we need to
add this to KIWIManager at all. Let the KIWIManagerZypper implementation add
the data in it's constructor rather than pushing this responsibility to the
base class.
Robert
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.