https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c2 Robert Schweikert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rschweikert@suse.com --- Comment #2 from Robert Schweikert 2013-02-04 16:01:41 UTC --- I have a couple of concerns with this patch, not necessarily with the idea. Today the command line of kiwi allows for the selection of a "procedure" , i.e. prepare, create, build, create a password, check the XML, and/or the over ride of settings in the config.xml file. I would rather not see kiwi allow command line options that are command line options of other software kiwi uses. The next thing we'll have to do is support all the command line options of tar, rsync, cp and whatever else we use under the covers. Last but not least there are a plethora of command line options for the other package managers. However, in general the request to let the user influence the behavior of the package manager is certainly reasonable. I would therefore propose that we add this to the XML in some way. <packaManagerOption name=".....">.......</packageManagerOption> or alternatively we could look for an use a packageManager config file. Either way we would preserve the consistency of the current kiwi command line interface, i.e. only accept procedures of XML over rides, and we can implement the requested functionality. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c4 --- Comment #4 from Robert Schweikert 2013-02-05 00:11:38 UTC --- (In reply to comment #3)

I could look into kiwi's xml parsing mechanisms and try to rewrite the patch such that it uses an entry in config.xml.

Well the XML is in flux right now and it will be difficult to add new stuff for a while.

Marcus, what do you think?

...

<packaManagerOption name=".....">.......</packageManagerOption> The option in question only applies to zypper, and in particular only to the install subcommand of zypper (in contrast to e.g. addrepo), so a future-proof option name would probably be "zypperInstallDownloadMode" or something like that.

Yes, this option only applies to zypper, but every package manager we support has a plethora of command line options. Today you need --download-<mode> someone else will need --another-option tomorrow. It is not reasonable to expect for kiwi to parse them all and pass them along to the various package managers. Thus from a kiwi perspective we have to find a way to generalize the concept such that it can be applied in a general sense. The general concept is reasonably obvious as "Influence package manager behavior", based on what we already have the next level is also reasonably obvious "support in the XML" however, the details are not necessarily very obvious. Currently I would lean toward letting the user provide a package manager options file at the top level of the configuration directory and encode the name of the file in the XML. But I have not thought through the consequences this or a enumerated option where each option passed shows up in the XML. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c6 --- Comment #6 from Robert Schweikert 2013-02-05 10:41:38 UTC --- kiwi wouldn't have to require that the package manager config file is in the format the package manager expects it's config file to be. We could simply document that the package manager config file lives at the top level of the configuration directory and contains one key-value pair for each command line option of the package manager involved. The kiwi code can simply parse the file and add each option (if not already used by kiwi itself) to the command line when the package manager is invoked. This is very generic and could work for any package manager. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

[zypper] verbose= [install] download=as-needed will add "--verbose" to /every/ zypper command line (somewhere before the subcommand), and "--download as-needed" whenever zypper is called with the "install" subcommand. Hence it yields command lines like zypper --root /bla/bla --verbose install --auto-agree-with-licenses --download as-needed some_package. If this is acceptable to you I can add some lines of documentation to the

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c8 --- Comment #8 from Yarny Yarny 2013-03-10 14:46:13 UTC --- Created an attachment (id=529045) --> (http://bugzilla.novell.com/attachment.cgi?id=529045) [PATCH] Add config.xml element "packagemanager-configfile" How about this patch? It adds an element <packagemanager-configfile>, which is only evaluated if the packagemanager is "zypper". In that case, the file which is given by the element's text is interpreted as ini-file, e.g. patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c10 --- Comment #10 from Marcus Schaefer 2013-03-18 09:36:12 UTC --- I agree to all points mentioned in #9 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c12 Yarny Yarny changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|Yarny@public-files.de | --- Comment #12 from Yarny Yarny 2013-03-18 10:25:17 UTC --- Yes, I intend to do so. I need some time (~1 month), however, since my perl proficiency is quite premature. Just to be sure: Since Robert mentiones "KIWIManagerZypper", you're expecting a patch against the master branch, not against KIWI-503-SuSE-12-2-Devel (as I did before)..? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c14 Marcus Schaefer changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ms@suse.com |Yarny@public-files.de --- Comment #14 from Marcus Schaefer 2013-03-27 20:35:06 UTC --- assigning to developer -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c16 --- Comment #16 from Robert Schweikert 2013-04-19 16:46:38 UTC --- The filename for the config file should be stored in the KIWIXMLPreferenceData class and should be returned by this class rather than by KIWIXML. The method name should indicate that a file name is being returned. The expected location of the package manager config file needs to be documented. The warning about ignoring the package manager configuration file should be in the XMLValidator and not in the PackageManager object as this is an XML inconsistency rather than a PackagManager issue. There is an issue in the case where the preferences from the user description get merged with the boot image description. In this case the name of the package manager config file will be defined, but the boot image description will not contain the file, thus "tie %cfgini, 'Config::IniFiles', ...." will probably fail in some weird way. There is no protection against this case. Rather than __generate... you want to implement a __getCmdArgsFromCfgFile method that delivers the arguments as a string. The string usage is more flexible as we can use it in concatenation. We also recently changed our naming convention. methods intended for overwriting should start with a v_. However, for now I do not think we need to add this to KIWIManager at all. Let the KIWIManagerZypper implementation add the data in it's constructor rather than pushing this responsibility to the base class. Robert -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c18 --- Comment #18 from Yarny Yarny 2013-06-17 15:06:37 UTC --- Created an attachment (id=544429) --> (http://bugzilla.novell.com/attachment.cgi?id=544429) 7 commits which implement a <packagemanager-arguments> tag The attached commits implement idea I of Comment #17. They include some documentation. Within the <preferences> section there is now a <packagemanager-arguments> element (with an optional subcommand attribute) which may contain command-line arguments for the package manager. KIWIManagerZypper adds these arguments to the respective zypper invocations. Apparently kiwi does not forward the arguments to the boot image creation step anymore. I don't really understand the paths through which the configuration is pushed during the image creation process. However, as I understand the content of the system/boot/ directory, the boot image descriptions declare their own package manager. If that is correct, I guess it is a good idea that the boot image description may also define their own package manager arguments. What do you think about it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c20 --- Comment #20 from Robert Schweikert 2013-07-31 06:41:01 UTC --- Hi, Sorry, been extremely busy and even the restructuring work in the XML had to take a back seat. I did take an initial look at this a while back but have not gotten around to come back to it, sorry. If I recall correctly more changes would be needed. But as we had pointed out very early on, this change comes at a very inopportune time in the middle of the XML processing restructuring, thus changes that are not directly related to the restructuring are not very high on the priority list. The feature as such is reasonable and it'll get into the code base, but you'll have to be patient, sorry. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=801920 https://bugzilla.novell.com/show_bug.cgi?id=801920#c22 --- Comment #22 from Yarny Yarny 2014-08-07 15:36:47 UTC --- Created an attachment (id=601555) --> (http://bugzilla.novell.com/attachment.cgi?id=601555) 8 commits which implement a <packagemanager-arguments> tag (based on v5.06.145) Hi, is there still a chance to get this thing merged into the kiwi code base? I rebased my change sets from about a year ago; the patches attached to this comment apply cleanly on v5.06.145. I tested them with the suse-13.1-JeOS template on current openSUSE 13.1. The runTests script does not yield any output (without arguments, and when applied to the KIWI*.pm files which are touched by my patches); I hope that means everything is OK. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=801920 --- Comment #24 from Yarny Yarny --- Created attachment 608977 --> http://bugzilla.novell.com/attachment.cgi?id=608977&action=edit 8 commits which implement a <packagemanager-arguments> tag (based on v7.01.5) The new bugzilla complains about me not taking care of this bug, so I hereby send a rebased patch set (applies to v7.01.5, but this time I didn't test it), and... -- You are receiving this mail because: You are on the CC list for the bug.