On Monday 12 July 2010 09:49:49 Adrian Schröter wrote:
On Friday 09 July 2010 19:53:40 Jan-Simon Möller wrote: [...]
+maintainer_13: + role_id: 2 + static_permission_id: 13 + +maintainer_16: + role_id: 2 + static_permission_id: 16
A bit more speaking names would maybe nicer, if possible. Like "private_source_owner" or "outside_user".
Maybe you could also re-use existing user definitions ?
But no objections.
Just followed the mass here ;) - you're right, adding more naming.
diff --git a/src/api/test/fixtures/static_permissions.yml b/src/api/test/fixtures/static_permissions.yml index cf994ae..d41fb04 100644 --- a/src/api/test/fixtures/static_permissions.yml +++ b/src/api/test/fixtures/static_permissions.yml @@ -50,3 +50,18 @@ local_create_package: id: 10 title: create_package
+download_binaries: + id: 11 + title: download_binaries + +source_access: + id: 12 + title: source_access + +private_view: + id: 13 + title: private_view + +access: + id: 16 + title: access
Can you please document here (in comments), what these roles are ? yes. Esp. the difference between source_access and access is unclear to me. It is imho not obvious from the "access" name what it is supposed to do. In short: soure_access blocks _only_ access to the source files. All other is visible. "access" protects all -> aka only visible by maintainer. @Martin can elaborate more.
Best, Jan-Simon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org