[opensuse-buildservice] [Patch] [0/2] First ACL testsuite bits / search_controller

older
[opensuse-buildservice] Reminder:...

Jan-Simon Möller

9 Jul 2010 9 Jul '10

17:52

Hi all! Please review these 2 patches. They're adding the first ACL testsuite bits. Either pull from git://gitorious.org/~dl9pf/opensuse/dl9pf-build-service.git or accept the merge request #11. Best, Jan-Simon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Show replies by date

Jan-Simon Möller

9 Jul 9 Jul

17:53

New subject: [opensuse-buildservice] [Patch] [1/2] First ACL testsuite bits / search_controller

commit b30369bb2ff0b6dc75d6a402c444585ef8423920 Author: Jan-Simon Möller Date: Fri Jul 9 18:45:47 2010 +0200 [api] Add more fixtures for ACL tests: static permission tables. Signed-off-by: Jan-Simon Möller diff --git a/src/api/test/fixtures/roles_static_permissions.yml b/src/api/test/fixtures/roles_static_permissions.yml index 80e5207..79a65f8 100644 --- a/src/api/test/fixtures/roles_static_permissions.yml +++ b/src/api/test/fixtures/roles_static_permissions.yml @@ -59,3 +59,19 @@ maintainer_9: maintainer_10: role_id: 2 static_permission_id: 10 + +maintainer_11: + role_id: 2 + static_permission_id: 11 + +maintainer_12: + role_id: 2 + static_permission_id: 12 + +maintainer_13: + role_id: 2 + static_permission_id: 13 + +maintainer_16: + role_id: 2 + static_permission_id: 16 diff --git a/src/api/test/fixtures/static_permissions.yml b/src/api/test/fixtures/static_permissions.yml index cf994ae..d41fb04 100644 --- a/src/api/test/fixtures/static_permissions.yml +++ b/src/api/test/fixtures/static_permissions.yml @@ -50,3 +50,18 @@ local_create_package: id: 10 title: create_package +download_binaries: + id: 11 + title: download_binaries + +source_access: + id: 12 + title: source_access + +private_view: + id: 13 + title: private_view + +access: + id: 16 + title: access -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Adrian Schröter

12 Jul 12 Jul

07:49

New subject: [opensuse-buildservice] [Patch] [1/2] First ACL testsuite bits / search_controller

On Friday 09 July 2010 19:53:40 Jan-Simon Möller wrote: ...

...

diff --git a/src/api/test/fixtures/roles_static_permissions.yml b/src/api/test/fixtures/roles_static_permissions.yml index 80e5207..79a65f8 100644 --- a/src/api/test/fixtures/roles_static_permissions.yml +++ b/src/api/test/fixtures/roles_static_permissions.yml @@ -59,3 +59,19 @@ maintainer_9: maintainer_10: role_id: 2 static_permission_id: 10 + +maintainer_11: + role_id: 2 + static_permission_id: 11 + +maintainer_12: + role_id: 2 + static_permission_id: 12 + +maintainer_13: + role_id: 2 + static_permission_id: 13 + +maintainer_16: + role_id: 2 + static_permission_id: 16

A bit more speaking names would maybe nicer, if possible. Like "private_source_owner" or "outside_user". Maybe you could also re-use existing user definitions ? But no objections.

...

diff --git a/src/api/test/fixtures/static_permissions.yml b/src/api/test/fixtures/static_permissions.yml index cf994ae..d41fb04 100644 --- a/src/api/test/fixtures/static_permissions.yml +++ b/src/api/test/fixtures/static_permissions.yml @@ -50,3 +50,18 @@ local_create_package: id: 10 title: create_package

+download_binaries: + id: 11 + title: download_binaries + +source_access: + id: 12 + title: source_access + +private_view: + id: 13 + title: private_view + +access: + id: 16 + title: access

Can you please document here (in comments), what these roles are ? Esp. the difference between source_access and access is unclear to me. It is imho not obvious from the "access" name what it is supposed to do. thanks adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Jan-Simon Möller

08:30

New subject: [opensuse-buildservice] [Patch] [1/2] First ACL testsuite bits / search_controller

On Monday 12 July 2010 09:49:49 Adrian Schröter wrote:

...

On Friday 09 July 2010 19:53:40 Jan-Simon Möller wrote: [...]

...
+maintainer_13: + role_id: 2 + static_permission_id: 13 + +maintainer_16: + role_id: 2 + static_permission_id: 16

A bit more speaking names would maybe nicer, if possible. Like "private_source_owner" or "outside_user".

Maybe you could also re-use existing user definitions ?

But no objections.

Just followed the mass here ;) - you're right, adding more naming.

...

...
diff --git a/src/api/test/fixtures/static_permissions.yml b/src/api/test/fixtures/static_permissions.yml index cf994ae..d41fb04 100644 --- a/src/api/test/fixtures/static_permissions.yml +++ b/src/api/test/fixtures/static_permissions.yml @@ -50,3 +50,18 @@ local_create_package: id: 10 title: create_package

+download_binaries: + id: 11 + title: download_binaries + +source_access: + id: 12 + title: source_access + +private_view: + id: 13 + title: private_view + +access: + id: 16 + title: access

Can you please document here (in comments), what these roles are ? yes. Esp. the difference between source_access and access is unclear to me. It is imho not obvious from the "access" name what it is supposed to do. In short: soure_access blocks _only_ access to the source files. All other is visible. "access" protects all -> aka only visible by maintainer. @Martin can elaborate more.

Best, Jan-Simon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Jan-Simon Möller

9 Jul 9 Jul

17:54

New subject: [opensuse-buildservice] [Patch] [2/2] First ACL testsuite bits / search_controller

commit e1801a2aced786049941e306d4b33ce159dad45a Author: Jan-Simon Möller Date: Fri Jul 9 19:41:21 2010 +0200 [api] Test search on HiddenProject and HiddenProject/pack with valid and invalid user. Signed-off-by: Jan-Simon Möller diff --git a/src/api/test/functional/search_controller_test.rb b/src/api/test/functional/search_controller_test.rb index 53cffc6..a529571 100644 --- a/src/api/test/functional/search_controller_test.rb +++ b/src/api/test/functional/search_controller_test.rb @@ -7,6 +7,13 @@ class SearchControllerTest < ActionController::IntegrationTest def setup @tom = User.find_by_login("tom") @tscholz = User.find_by_login("tscholz") + + @controller = SourceController.new + @controller.start_test_backend + + Suse::Backend.put( '/source/HiddenProject/_meta', DbProject.find_by_name('HiddenProject').to_axml) + Suse::Backend.put( '/source/HiddenProject/pack/_meta', DbPackage.find_by_project_and_name("HiddenProject", "pack").to_axml) + Suse::Backend.put( '/source/HiddenProject/pack/my_file', "Protected Content") end def test_search_unknown @@ -78,5 +85,49 @@ class SearchControllerTest < ActionController::IntegrationTest assert_select "status[code] > summary", /illegal xpath attribute/ end + # >>> Testing HiddenProject - flag "access" set to "disabled" + def test_search_hidden_project_with_valid_user + # user is maintainer, thus access to hidden project is allowed + prepare_request_with_user "adrian", "so_alone" + get "/search/project", :match => '[@name="HiddenProject"]' + assert_response :success + assert_tag :tag => 'collection', :children => { :count => 1 } + #<project name="HiddenProject"> + assert_tag :child => { :tag => 'project', :attributes => { :name => 'HiddenProject'} } + end + def test_search_hidden_project_with_invalid_user + # user is not maintainer - project has to be invisible + prepare_request_with_user "tscholz", "asdfasdf" + get "/search/project", :match => '[@name="HiddenProject"]' + assert_response :success + assert_tag :tag => 'collection', :children => { :count => 0 } + end + # <<< Testing HiddenProject - flag "access" set to "disabled" + + # >>> Testing package inside HiddenProject - flag "access" set to "disabled" in Project + def test_search_hidden_project_with_valid_user + # user is maintainer, thus access to hidden package is allowed + prepare_request_with_user "adrian", "so_alone" + get "/search/package", :match => '[@name="pack" and @project="HiddenProject"]' + assert_response :success + assert_tag :tag => 'collection', :children => { :count => 1 } + assert_tag :child => { :tag => 'package', :attributes => { :name => 'pack', :project => "HiddenProject"} } + puts "\n" + puts @response.body + puts "\n" + end + def test_search_hidden_project_with_invalid_user + # user is not maintainer - package has to be invisible + prepare_request_with_user "tscholz", "asdfasdf" + get "/search/package", :match => '[@name="pack" and @project="HiddenProject"]' + assert_response :success + assert_tag :tag => 'collection', :children => { :count => 0 } + puts "\n" + puts @response.body + puts "\n" + + end + # <<< Testing package inside HiddenProject - flag "access" set to "disabled" in Project + end -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Jan-Simon Möller

17:55

New subject: [opensuse-buildservice] Re: [Patch] [0/2] First ACL testsuite bits / search_controller

On Friday 09 July 2010 19:52:31 you wrote:

...

Hi all! Please review these 2 patches. They're adding the first ACL testsuite bits.

Either pull from git://gitorious.org/~dl9pf/opensuse/dl9pf-build-service.git or accept the merge request #11.

Sigh - forgot to remove the debug output - fixed in repo and #12.

...

Best, Jan-Simon

-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

5030

Age (days ago)

5033

Last active (days ago)

List overview

Download

5 comments

2 participants

participants (2)

Adrian Schröter
Jan-Simon Möller