https://bugzilla.novell.com/show_bug.cgi?id=221311 hmacht@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |INVALID ------- Comment #12 from hmacht@novell.com 2007-03-04 13:45 MST ------- (In reply to comment #11)
And still: the dockutils have a bug with regard to detecting x60, because in the file 60x60 there is a wrong comparison IMHO (see comment #5) Therefore you shouldn't close this, whether you accept the patches that make keys on X60 work or not.
Stefan is completely right here. Hotkey handling just doesn't fit into dockutils. But the other thing is a bug. Thanks for reporting it. I opened another bug for it (251130).
Please take a look into the line [ $MODEL == Thinkpad x60 ] &&
this is wrong and should say [ $MODEL = THINKPAD X60 ] ||
and the patch to dockutils with uppercasifying the return value of hal-get-property should be applied.
This file is dedicatet to X60 I assume but what happens with the distributed version is that for every laptop *not* named Thinkpad X60 the file 60x60 is processed, what IMHO is wrong.
I'll apply something like this: -[ "$MODEL" == "Thinkpad X60" ] && exit 0; +MODEL="`echo $MODEL | tr '[a-z]' '[A-Z]'`" +[ "$MODEL" = "THINKPAD X60" ] || exit 0; I don't think uppercasing the content of the MODEL variable for all possible hooks which maybe come in the future is a good idea. The hook itself should decide in which extend they make use of the global data. Nevertheless, the initially reported issue in this bug is INVALID ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.