[Bug 221311] New: dockutils do not rescan the scsi bus correctly
https://bugzilla.novell.com/show_bug.cgi?id=221311 Summary: dockutils do not rescan the scsi bus correctly Product: openSUSE 10.2 Version: Beta 2 plus Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Mobile Devices AssignedTo: hmacht@novell.com ReportedBy: seife@novell.com QAContact: qa@suse.de OtherBugsDependingO 215208 nThis: This code in /usr/lib/dockutils/common_functions cannot work correctly: for J in $PATH/device/target*; do test -e $J && TARGET=1 done if [ $TARGET = 0 ]; then # rescan the host echo "rescanning $PATH" echo "- - -" > $PATH/scan fi Because it is only rescanning the host, if the target does not exist. Also the usage of $PATH is dubious. I'll attach a patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 ------- Comment #1 from seife@novell.com 2006-11-15 08:51 MST ------- Created an attachment (id=105429) --> (https://bugzilla.novell.com/attachment.cgi?id=105429&action=view) fix the rescan logic this fixes the "if $TARGET=0" to "if TARGET=1" and also changes all PATH to SYS_PATH to avoid future surprises. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 seife@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #2 from seife@novell.com 2006-11-15 12:53 MST ------- It actually only should rescan the bus if the target was removed (by undocking) before, so the code is correct. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 dieter.jurzitza@t-online.de changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID | ------- Comment #3 from dieter.jurzitza@t-online.de 2007-02-28 13:56 MST ------- Hi, I recently got a X60 lenovo notebook and found that the docutils are broken with regard to X60 handling. Please find attached: - a patch that makes 60x60 work as expected, - a patch that integrates FN-F7 support - a new package i810switcht that is mandatory to get this going on openSUSE 10.2 The minimum change would be the modifications I introduced with the MODEL variable because on my X60 the name is ThinkPad X60 and *not* Thinkpad X60, so capitalizing is IMHO a good idea. i810switch is for user convenience - if you have a better idea, please let me know :-) Take care Dieter Jurzitza -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 ------- Comment #4 from dieter.jurzitza@t-online.de 2007-02-28 13:57 MST ------- Created an attachment (id=121672) --> (https://bugzilla.novell.com/attachment.cgi?id=121672&action=view) This is only a renaming for consistency reasons -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 ------- Comment #5 from dieter.jurzitza@t-online.de 2007-02-28 13:59 MST ------- Created an attachment (id=121673) --> (https://bugzilla.novell.com/attachment.cgi?id=121673&action=view) This actually fixes the handling of X60 (if I got the logic right) This patch provides two functions: 1.) make sure that X60 is treated as X60 2.) fix the breakout condition in 60x60 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 ------- Comment #6 from dieter.jurzitza@t-online.de 2007-02-28 14:01 MST ------- Created an attachment (id=121675) --> (https://bugzilla.novell.com/attachment.cgi?id=121675&action=view) This supplies FN-F7 support for X60 laptops By the help of this patch FN-F7 start to work. For some strange reason /proc/acpi/ibm/video does not react to echo "video_switch" > /proc/acpi/ibm/video The screen remains active. Probably the same issue as with i810switch which had to be patched to treat i945 identical to i855 with regard to video switching. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 ------- Comment #7 from dieter.jurzitza@t-online.de 2007-02-28 14:03 MST ------- Created an attachment (id=121676) --> (https://bugzilla.novell.com/attachment.cgi?id=121676&action=view) This is the new specfile for docutils -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 ------- Comment #8 from dieter.jurzitza@t-online.de 2007-03-02 05:10 MST ------- Created an attachment (id=122014) --> (https://bugzilla.novell.com/attachment.cgi?id=122014&action=view) patch-update for x60 / lenovo This enlargement of the dockutils patch I readily provided makes the function key FN-F2 (lock screen) work on X for kde-users, will need tweaking on gnome. Take care Dieter Jurzitza -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 ------- Comment #9 from dieter.jurzitza@t-online.de 2007-03-02 08:15 MST ------- Created an attachment (id=122057) --> (https://bugzilla.novell.com/attachment.cgi?id=122057&action=view) Fix for 122014 - do not use 122014 Sorry for the inconvinience, I somehow messed my xhost + whatsoever commands and had a function that was actually not there. This one ought to work - testers are welcome. Dieter Jurzitza -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 seife@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |INVALID ------- Comment #10 from seife@novell.com 2007-03-02 08:37 MST ------- sorry, but your stuff has absolutely nothing to do with the bug i reported (which was clearly invalid, since i did something wrong that was not supposed to work anyway). Dockutils are not the place to put your stuff in. Your stuff needs to go into HAL and the desktop applets. I won't preempt Holgers decision, but i am pretty sure that dockutils is absolutely the wrong place for that. Dockutils is for docking and undocking, maybe ejecting CDROM drive, but not for hacky hotkey handlers. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 dieter.jurzitza@t-online.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dieter.jurzitza@t-online.de Status|RESOLVED |REOPENED Resolution|INVALID | ------- Comment #11 from dieter.jurzitza@t-online.de 2007-03-04 04:44 MST ------- And still: the dockutils have a bug with regard to detecting x60, because in the file 60x60 there is a wrong comparison IMHO (see comment #5) Therefore you shouldn't close this, whether you accept the patches that make keys on X60 work or not. Please take a look into the line [ $MODEL == Thinkpad x60 ] && this is wrong and should say [ $MODEL = THINKPAD X60 ] || and the patch to dockutils with uppercasifying the return value of hal-get-property should be applied. This file is dedicatet to X60 I assume but what happens with the distributed version is that for every laptop *not* named Thinkpad X60 the file 60x60 is processed, what IMHO is wrong. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=221311 hmacht@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |INVALID ------- Comment #12 from hmacht@novell.com 2007-03-04 13:45 MST ------- (In reply to comment #11)
And still: the dockutils have a bug with regard to detecting x60, because in the file 60x60 there is a wrong comparison IMHO (see comment #5) Therefore you shouldn't close this, whether you accept the patches that make keys on X60 work or not.
Stefan is completely right here. Hotkey handling just doesn't fit into dockutils. But the other thing is a bug. Thanks for reporting it. I opened another bug for it (251130).
Please take a look into the line [ $MODEL == Thinkpad x60 ] &&
this is wrong and should say [ $MODEL = THINKPAD X60 ] ||
and the patch to dockutils with uppercasifying the return value of hal-get-property should be applied.
This file is dedicatet to X60 I assume but what happens with the distributed version is that for every laptop *not* named Thinkpad X60 the file 60x60 is processed, what IMHO is wrong.
I'll apply something like this: -[ "$MODEL" == "Thinkpad X60" ] && exit 0; +MODEL="`echo $MODEL | tr '[a-z]' '[A-Z]'`" +[ "$MODEL" = "THINKPAD X60" ] || exit 0; I don't think uppercasing the content of the MODEL variable for all possible hooks which maybe come in the future is a good idea. The hook itself should decide in which extend they make use of the global data. Nevertheless, the initially reported issue in this bug is INVALID ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com