On Tue, Jan 13, 2009 at 10:22:02AM +0100, Johannes Meixner wrote:

...

In this case example code is here:

Wizard::SetContents(caption, contents, help, true, true); Wizard::SetNextButton(`next, Label::OKButton()); Wizard::SetAbortButton(`abort, Label::CancelButton()); Wizard::HideBackButton();

I already implemented Martin's wish in the printer and scanner module.

But according to how I understand Martin's style guide there is no longer a button with abort functionality.

Therefore I implemented Martin's wish different than your code above, see for an example https://bugzilla.novell.com/show_bug.cgi?id=443684#c1

Wizard::SetContentsButtons ( caption, contents, HELPS["add_driver_dialog"]:"", // Set a new label for the "back" button: Label::CancelButton(), // Set a new label for the "next" button: Label::OKButton() ); Wizard::HideAbortButton();

I assume that this looks the same, but the consequence is that "Cancel" gets the F8 key like Back (wrong) and not F9 like Abort (right): http://en.opensuse.org/YaST/Style_Guide#Function_keys_.28F_keys.29 -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org

Johannes Meixner wrote:

When I implemented Martin's wish, the style guide reads different! When I implemented Martin's wish, the style guide did read: "Cancel - Closes the window and returns to the overview." But now it suddenly reads: "Cancel - If the user presses Cancel the module is closed."

Who the hell changed the style guide in an incompatible way! I cannot work this way! I will not change my code again! I will not implement a "refernce" module because it is totally useless at all when the style guide changes all the time!

Mschmidkunz, 11:54, 28 November 2008 See http://en.opensuse.org/index.php?title=YaST%2FStyle_Guide&diff=80310&oldid=79765 L.

...

In this case example code is here:

Wizard::SetContents(caption, contents, help, true, true); Wizard::SetNextButton(`next, Label::OKButton()); Wizard::SetAbortButton(`abort, Label::CancelButton()); Wizard::HideBackButton();

What about new function Wizard::SetStandaloneContents() ?

What about Wizard::OpenCancelOKDialog() ?

L.

Done in yast2-2.18.2 (new function Wizard::OpenCancelOKDialog()) M. -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org

Hello, On Jan 16 12:48 Martin Schmidkunz wrote (shortened):

* Having an activated "Back" button and an activated "Cancel" button in an one screen dialog (e.g. overview) does not make any sense because the visible consequences of the buttons are the same: I click on the button, the module disappears and no changes are preserved. Secondly why should I have a "Back" button when there is no next screen I can go to?

It seems you mix up the special case "overview dialog" with any other "one screen dialog". The "overview dialog" has the meaning to be the very first dialog. Therefore in the special case of the very first dialog there exists nothing whereto go back in the workflow so that for the special case of the very first dialog a button with back functionality and a button with abort functionality have the same effect which is: Leave the whole module. In contrast any other "one screen dialog" could be nested somewhere deep in the workflow structure of the module where it makes a big difference if there is a button with back functionality which goes back in the workflow to a point which makes sense in the particular case (usually the "overview dialog" but it could be any other dialog) compared to a button which has abort functionality so that the whole module is closed.

The text line: "Cancel - Closes the module and returns to the overview" was modified by me, Johannes. I did that in agreement with you as a result of your comment, that when having an opening a module and the user presses "Cancel" there is no overview the user can return to.

There is a misunderstanding. I think it would help to fix the confusion to make a strict difference between the very first dialog and any other "one screen dialog". Note that the "overview dialog" is the very first dialog only after the module was started but not after the user came back to the "overview dialog" when finishing a particular part of the workflow - i.e. when he did: "overview dialog" -> "one screen dialog" -> "overview dialog" The old version "Cancel - Closes the window and returns to the overview." works well because the meaning is a back functionality and it does not matter very much when there is no longer an abort functionality because from anywhere in the module [Cancel] -> [Cancel] -> [Cancel] -> [Cancel] -> [Cancel] -> ... would eventually leave the module (without having any settings applied in the system). In contrast the new version "Cancel - If the user presses Cancel the module is closed." does not work well because the meaning is an immediate abort functionality of the whole module. But there is no button which provides a back functionality. Therefore when the user selected wrong stuff anywhere in the module there is nothing except the abort functionality of the whole module where he can only discard all his changes. I.e. there is no longer a functionality to get out only from a current part of the workflow (e.g. get out only from one "one screen dialog") and discard only the changes of this current part (i.e. there is no longer a back functionality). Kind Regards Johannes Meixner -- SUSE LINUX Products GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany AG Nuernberg, HRB 16746, GF: Markus Rex -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org For additional commands, e-mail: yast-devel+help@opensuse.org