[yast-devel] Re: [yast-commit] r67465 - in /trunk/nfs-client: package/yast2-nfs-client.changes src/Nfs.ycp src/ui.ycp
On Thu, 16 Feb 2012 13:22:20 -0000 mfilka@svn2.opensuse.org wrote:
Author: mfilka Date: Thu Feb 16 14:22:19 2012 New Revision: 67465
URL: http://svn.opensuse.org/viewcvs/yast?rev=67465&view=rev Log:
removed some dead code, whitespaces
Great, don't hesitate to move out all garbage you found ;) Just I recommend to separate removing dead code and whispaces changes to different commit, so it will be easier to detect. For whitespace correction I recommend indent tool, which can take it in one round. Josef P.S. If you find indentation rules strange, then you are not alone. -- Josef Reidinger Software Engineer Appliance Department SUSE LINUX, s. r. o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic jreidinger@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
Great, don't hesitate to move out all garbage you found ;) ... no problem. Hopefully innocents will not suffer ;-)
Just I
recommend to separate removing dead code and whispaces changes to different commit, so it will be easier to detect. ... ok. next time ;-)
For whitespace correction I recommend indent tool, which can take it in one round. ... use vim's formating capabilities ... but will try
Michal Filka -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 02/16/2012 02:55 PM, Josef Reidinger wrote:
P.S. If you find indentation rules strange, then you are not alone.
Yes, strange rules can be either ignored or rather changed. Nothing is engraved into golden plates... Lukas -- Lukas Ocilka, Appliances Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Mon, 20 Feb 2012 10:34:28 +0100 Lukas Ocilka <lukas.ocilka@suse.cz> wrote:
On 02/16/2012 02:55 PM, Josef Reidinger wrote:
P.S. If you find indentation rules strange, then you are not alone.
Yes, strange rules can be either ignored or rather changed. Nothing is engraved into golden plates...
Lukas
I already suggested to move away from mix of tabs and spaces and keep indentation level to four and already expand tabs. Nowadays, consumed space is important so we need not to compress eight space to one tab ( it is annoying on systems where tab size is not eight! because we use mixture, then first and second level of indentation in case of ts=4 is not recognizable and in case of ts=2 it is complete mess ). So if everyone agree, we can start using new rules ( what is nice that we need not to convert all text, just for new lines use new rule, and everything looks fine ). Josef -- Josef Reidinger Software Engineer Appliance Department SUSE LINUX, s. r. o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic jreidinger@suse.com SUSE -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On 02/20/2012 10:48 AM, Josef Reidinger wrote:
I already suggested to move away from mix of tabs and spaces and keep indentation level to four and already expand tabs. Nowadays, consumed space is important so we need not to compress eight space to one tab ( it is annoying on systems where tab size is not eight! because we use mixture, then first and second level of indentation in case of ts=4 is not recognizable and in case of ts=2 it is complete mess ). So if everyone agree, we can start using new rules ( what is nice that we need not to convert all text, just for new lines use new rule, and everything looks fine ).
I'm fine with four spaces (and no tabs) ... if I find out how to tell my Midnight Commander not to convert all the spaces automatically :) ;) Lukas -- Lukas Ocilka, Appliances Department SUSE LINUX s.r.o., Praha -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
On Mon, Feb 20, 2012 at 10:59:46AM +0100, Lukas Ocilka wrote:
On 02/20/2012 10:48 AM, Josef Reidinger wrote:
I already suggested to move away from mix of tabs and spaces and keep indentation level to four and already expand tabs. Nowadays, consumed space is important so we need not to compress eight space to one tab ( it is annoying on systems where tab size is not eight! because we use mixture, then first and second level of indentation in case of ts=4 is not recognizable and in case of ts=2 it is complete mess ). So if everyone agree, we can start using new rules ( what is nice that we need not to convert all text, just for new lines use new rule, and everything looks fine ).
I'm fine with four spaces (and no tabs) ... if I find out how to tell my Midnight Commander not to convert all the spaces automatically :) ;)
man mcedit... ~/.mc/ini [Midnight-Commander] editor_fill_tabs_with_spaces=1 -- Martin Vidner, YaST developer http://en.opensuse.org/User:Mvidner Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu
On 02/20/2012 02:57 PM, Martin Vidner wrote:
man mcedit...
~/.mc/ini [Midnight-Commander] editor_fill_tabs_with_spaces=1
Thanks I thought I would search for that next time I needed that info. BTW, don't use mcedit for editing that file :) Lukas -- To unsubscribe, e-mail: yast-devel+unsubscribe@opensuse.org To contact the owner, e-mail: yast-devel+owner@opensuse.org
participants (4)
-
Josef Reidinger -
Lukas Ocilka -
Martin Vidner -
Michal Filka