Hi Johannes! On Friday 16 of September 2011 08:59:18 Johannes Meixner wrote:
Hello Stanislav,
On Sep 15 13:05 Stanislav Visnovsky wrote (excerpt):
On Thursday 15 of September 2011 12:41:04 Johannes Meixner wrote:
On Sep 15 12:20 Stanislav Visnovsky wrote (excerpt):
All you need to do in a module now is to replace
Wizard::SetDesktopIcon("desktop-file-name");
to
Wizard::SetDesktopTitleAndIcon("desktop-file-name");
If you accept the patch, I will go through the modules and start to change them to use the new functionality.
I provide the newest printer module also for SLE_11, SLE_11_SP1, openSUSE_11.3, and openSUSE_11.4 via the Printing project in the openSUSE build service.
If Wizard::SetDesktopTitleAndIcon is not available there you would cause a regression by a backward-incomatible change.
So you would prefer not to change the title, correct? I can do the change using the old API if you prefer.
As far as I see the current printer module dialogs have meaningful titles which match to the dialog header text so that from my point of view everything seems to be o.k.
Those titles / header texts have been developed together with Martin Schmidkunz to ensure good usability (in particular to avoid titles / header texts which are meaningless for the user).
My original mail was talking about the 'window titles' - sorry for confusion. I've added 2 screenshots - before and after the change. I think I will send you a patch for consideration, you can then do a decision if you want to include it or not. Does it work for you? Stano
