Script 'mail_helper' called by ro
Hello packager,
This is just FYI. Your package was checked in in distribution "sle12"
by autobuild-member: ro.
Here comes the log...
---------------------------%<------------------------------
Hi,
here is the log from ci_new_pac /mounts/work_src_done/SLE12/yast2-ruby-bindings -> sle12
## BNC# 861529 : "Warning when creating partitioning proposal - default_target_proposal.rb:18: warning:" (NEW/)
Changes:
--------
--- /work/SRC/SUSE:SLE-12:GA/yast2-ruby-bindings/yast2-ruby-bindings.changes 2014-02-05 17:48:45.000000000 +0100
+++ /mounts/work_src_done/SLE12/yast2-ruby-bindings/yast2-ruby-bindings.changes 2014-02-13 17:08:32.000000000 +0100
@@ -1,0 +2,6 @@
+Mon Feb 10 13:43:23 UTC 2014 - jreidinger@suse.com
+
+- Do not unload clients after execution (BNC#861529)
+- 3.1.9
+
+-------------------------------------------------------------------
calling whatdependson for sle12-i586
Packages directly triggered for rebuild:
- yast2-ruby-bindings
- at least 75 other packages
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/SUSE:SLE-12:GA/yast2-ruby-bindings (Old)
and /mounts/work_src_done/SLE12/yast2-ruby-bindings (BS:build ID:32647 MAIL:yast-commit@opensuse.org) (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ruby-bindings", Maintainer is "yast-commit@opensuse.org"
Old:
----
yast2-ruby-bindings-3.1.8.tar.bz2
New:
----
yast2-ruby-bindings-3.1.9.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-ruby-bindings.spec ++++++
--- /var/tmp/diff_new_pack.098RQF/_old 2014-02-14 14:01:53.000000000 +0100
+++ /var/tmp/diff_new_pack.098RQF/_new 2014-02-14 14:01:53.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 3.1.8
+Version: 3.1.9
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Source0: yast2-ruby-bindings-%{version}.tar.bz2
++++++ yast2-ruby-bindings-3.1.8.tar.bz2 -> yast2-ruby-bindings-3.1.9.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/package/yast2-ruby-bindings.changes new/yast2-ruby-bindings-3.1.9/package/yast2-ruby-bindings.changes
--- old/yast2-ruby-bindings-3.1.8/package/yast2-ruby-bindings.changes 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/package/yast2-ruby-bindings.changes 2014-02-13 17:05:21.000000000 +0100
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Mon Feb 10 13:43:23 UTC 2014 - jreidinger@suse.com
+
+- Do not unload clients after execution (BNC#861529)
+- 3.1.9
+
+-------------------------------------------------------------------
Wed Feb 5 14:20:37 UTC 2014 - lslezak@suse.cz
- Builtins.y2milestone(),... marked as deprecated, use Yast::Logger
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/package/yast2-ruby-bindings.spec new/yast2-ruby-bindings-3.1.9/package/yast2-ruby-bindings.spec
--- old/yast2-ruby-bindings-3.1.8/package/yast2-ruby-bindings.spec 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/package/yast2-ruby-bindings.spec 2014-02-13 17:05:21.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 3.1.8
+Version: 3.1.9
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
Source0: yast2-ruby-bindings-%{version}.tar.bz2
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/src/binary/Builtin.cc new/yast2-ruby-bindings-3.1.9/src/binary/Builtin.cc
--- old/yast2-ruby-bindings-3.1.8/src/binary/Builtin.cc 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/src/binary/Builtin.cc 2014-02-13 17:05:21.000000000 +0100
@@ -31,7 +31,6 @@
#include "Y2YCPTypeConv.h"
#include "Y2RubyTypeConv.h"
#include "RubyLogger.h"
-#include "YRuby.h"
#include "Y2RubyUtils.h"
static VALUE rb_mSCR;
@@ -49,7 +48,6 @@
static VALUE call_builtin(const string &qualified_name, int argc, VALUE *argv)
{
- YRuby::yRuby();
extern StaticDeclaration static_declarations;
YaST::ee.setFilename(RSTRING_PTR(argv[0]));
YaST::ee.setLinenumber(FIX2INT(argv[1]));
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/src/ruby/yast/wfm.rb new/yast2-ruby-bindings-3.1.9/src/ruby/yast/wfm.rb
--- old/yast2-ruby-bindings-3.1.8/src/ruby/yast/wfm.rb 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/src/ruby/yast/wfm.rb 2014-02-13 17:05:21.000000000 +0100
@@ -207,21 +207,6 @@
)
end
return false
- ensure
- # unload the client class to ensure that the includes will be
- # fully initialized when running it next time
- # (Yast.include skips initialize_<include> calls when the include
- # module is already present in the target class)
- client_without_suffix = File.basename(client).sub(/\.rb$/, "")
- client_name = (client_without_suffix.
- gsub(/^./) { |s| s.upcase }.
- gsub(/[-_.]./) { |s| s[1].upcase } +
- "Client").to_sym
-
- if Yast.constants.include?(client_name)
- Yast.y2debug "Unloading client class #{client_name}"
- Yast.send(:remove_const, client_name)
- end
end
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/src/ruby/yast/yast.rb new/yast2-ruby-bindings-3.1.9/src/ruby/yast/yast.rb
--- old/yast2-ruby-bindings-3.1.8/src/ruby/yast/yast.rb 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/src/ruby/yast/yast.rb 2014-02-13 17:05:21.000000000 +0100
@@ -111,13 +111,27 @@
mod = Yast.const_get module_name
- return if target.class.include? mod
-
- target.class.send(:include, mod)
-
- method_name = "initialize_" + path_without_suffix.gsub(/[-.\/]/, "_")
-
- target.send method_name.to_sym, target if target.respond_to? method_name.to_sym
+ # if never included, then include
+ if !target.class.include? mod
+ target.class.send(:include, mod)
+ end
+
+ encoded_name = path_without_suffix.gsub(/[-.\/]/, "_")
+ initialized_variable = "@" + encoded_name + "initialized"
+ method_name = "initialize_" + encoded_name
+
+ # tricky condition. Here collide two yast features that had old ycp
+ # 1) in clients reapeated call results in new client object, but client base class
+ # is already defined, so not needed to include again, but it's
+ # needed to be reinitialized, so we need to call initialization method
+ # even if module is already included
+ # 2) if there is multi include, then only first one must call initialization
+ # because other calls are ignored
+ if target.respond_to?(method_name.to_sym) &&
+ !target.instance_variable_defined?(initialized_variable)
+ target.send(method_name.to_sym, target)
+ target.instance_variable_set(initialized_variable, true)
+ end
end
# imports component module with given name and create wrapper for it.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/tests/ruby/import_test.rb new/yast2-ruby-bindings-3.1.9/tests/ruby/import_test.rb
--- old/yast2-ruby-bindings-3.1.8/tests/ruby/import_test.rb 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/tests/ruby/import_test.rb 2014-02-13 17:05:21.000000000 +0100
@@ -7,11 +7,6 @@
require "yast"
class YcpImportTest < Yast::TestCase
- def setup
- module_path = File.expand_path("../modules",__FILE__)+'/'
- Yast.add_module_path module_path
- end
-
def test_import
Yast.import( "ExampleTestModule" )
assert Yast::ExampleTestModule.respond_to?(:sparc_map)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/tests/ruby/include/example.rb new/yast2-ruby-bindings-3.1.9/tests/ruby/include/example.rb
--- old/yast2-ruby-bindings-3.1.8/tests/ruby/include/example.rb 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/tests/ruby/include/example.rb 1970-01-01 01:00:00.000000000 +0100
@@ -1,11 +0,0 @@
-module Yast
- module ExampleInclude
- def initialize_example target
- @test = 15
- end
-
- def test_plus_five
- @test + 5
- end
- end
-end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/tests/ruby/include_test.rb new/yast2-ruby-bindings-3.1.9/tests/ruby/include_test.rb
--- old/yast2-ruby-bindings-3.1.8/tests/ruby/include_test.rb 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/tests/ruby/include_test.rb 2014-02-13 17:05:21.000000000 +0100
@@ -19,7 +19,7 @@
class DoubleIncludeTest < Module
def initialize
- YCP.include self, "example.rb"
+ Yast.include self, "example.rb"
@test = 5
# second include should not call again init, so @test is kept to 5
Yast.include self, "example.rb"
@@ -27,16 +27,11 @@
attr_reader :test
end
- DIT = IncludeTest.new
+ DIT = DoubleIncludeTest.new
end
class IncludeTest < Yast::TestCase
- def setup
- include_path = File.expand_path("../include",__FILE__)+'/'
- Yast.add_include_path include_path
- end
-
def test_include
assert_equal 15, Yast::IT.test
end
Files old/yast2-ruby-bindings-3.1.8/tests/ruby/modules/ExampleTestModule.ybc and new/yast2-ruby-bindings-3.1.9/tests/ruby/modules/ExampleTestModule.ybc differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ruby-bindings-3.1.8/tests/ruby/modules/ExampleTestModule.ycp new/yast2-ruby-bindings-3.1.9/tests/ruby/modules/ExampleTestModule.ycp
--- old/yast2-ruby-bindings-3.1.8/tests/ruby/modules/ExampleTestModule.ycp 2014-02-05 15:40:42.000000000 +0100
+++ new/yast2-ruby-bindings-3.1.9/tests/ruby/modules/ExampleTestModule.ycp 1970-01-01 01:00:00.000000000 +0100
@@ -1,18 +0,0 @@
-//WARNING compile after each change!
-{
- module "ExampleTestModule";
-
- global string example_string = "x86_64";
-
- global map l = [["b","c"]];
- y2milestone ("clear list: %1", l[0,1]:"n" );
- y2milestone ("clear list: %1", l[0,2]:"n" );
- y2milestone ("clear list: %1", l[1,0]:"n" );
-
- term t = `a(`b,`c);
- y2milestone ("clear list: %1", t[1]:`n );
- y2milestone ("clear list: %1", t[2]:`n );
- y2milestone ("clear list: %1", t[0]:`n );
-
- map