Author: mvidner Date: Mon Jun 1 16:17:47 2009 New Revision: 57387 URL: http://svn.opensuse.org/viewcvs/yast?rev=57387&view=rev Log: Added error checks to silence warnings. Modified: trunk/core/liby2/src/Y2ProgramComponent.cc trunk/core/liby2util-r/src/ExternalProgram.cc trunk/core/liby2util-r/testsuite/test_chroot.cc Modified: trunk/core/liby2/src/Y2ProgramComponent.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/liby2/src/Y2ProgramComponent.cc?rev=57387&r1=57386&r2=57387&view=diff ============================================================================== --- trunk/core/liby2/src/Y2ProgramComponent.cc (original) +++ trunk/core/liby2/src/Y2ProgramComponent.cc Mon Jun 1 16:17:47 2009 @@ -265,8 +265,13 @@ { y2debug ("launchExternalProgram (%s, %s, ...)", argv[0], argv[1]); // Create socket-pair - pipe(to_external); - pipe(from_external); + int err; + err = pipe(to_external); + if (err != 0) + y2error("pipe failed: %s", strerror (errno)); + err = pipe(from_external); + if (err != 0) + y2error("pipe failed: %s", strerror (errno)); // Create module process Modified: trunk/core/liby2util-r/src/ExternalProgram.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/liby2util-r/src/ExternalProgram.cc?rev=57387&r1=57386&r2=57387&view=diff ============================================================================== --- trunk/core/liby2util-r/src/ExternalProgram.cc (original) +++ trunk/core/liby2util-r/src/ExternalProgram.cc Mon Jun 1 16:17:47 2009 @@ -217,8 +217,10 @@ // unix guru knowledge ;-) ) char name[512]; - ttyname_r(slave_tty, name, sizeof(name)); - ::close(open(name, O_RDONLY)); + int err = ttyname_r(slave_tty, name, sizeof(name)); + if (err == 0) + ::close(open(name, O_RDONLY)); + // else error } else { Modified: trunk/core/liby2util-r/testsuite/test_chroot.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/core/liby2util-r/testsuite/test_chroot.cc?rev=57387&r1=57386&r2=57387&view=diff ============================================================================== --- trunk/core/liby2util-r/testsuite/test_chroot.cc (original) +++ trunk/core/liby2util-r/testsuite/test_chroot.cc Mon Jun 1 16:17:47 2009 @@ -11,7 +11,7 @@ cout << "must specify directory to chroot to" << endl; return 1; } - char* aa[] = { "ls" , "-al", NULL }; + const char* aa[] = { "ls" , "-al", NULL }; // string aa = "ls"; ExternalProgram* prog = new ExternalProgram(aa, ExternalProgram::Stderr_To_Stdout, false, -1, true, argv[1]); -- To unsubscribe, e-mail: yast-commit+unsubscribe@opensuse.org For additional commands, e-mail: yast-commit+help@opensuse.org