Re: [vhostmd] [PATCH] Make Xen Libraries really optional

Eduardo Otubo wrote:

The default behavior in the configure script was to make with_xenstore set to 'true', which caused the compilation to break in my case because I don't have xen libraries, therefore, xs.h

Now the default behavior is set according to its existence or not. Same thing for xenstat and xenctrl.

Signed-off-by: Eduardo Otubo --- configure.ac | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac index ee9c446..fb4309b 100644 --- a/configure.ac +++ b/configure.ac @@ -48,7 +48,7 @@ AC_ARG_ENABLE([libxenstat], ;; no) libxenstat=false ;; *) AC_MSG_ERROR(bad value ${enableval} for --enable-libxenstat) ;; - esac],[libxenstat=false]) + esac],[AC_CHECK_HEADER(xenstat.h, libxenstat=true, libxenstat=false)]) AM_CONDITIONAL(LIBXENSTAT, test x$libxenstat = xtrue)

# Configure argument to support using xenctrl library for vm enumeration @@ -60,7 +60,7 @@ AC_ARG_ENABLE([xenctrl], ;; no) xenctrl=false ;; *) AC_MSG_ERROR(bad value ${enableval} for --enable-xenctrl) ;; - esac],[xenctrl=false]) + esac],[AC_CHECK_HEADER(xenctrl.h, xenctrl=true, xenctrl=false,)]) AM_CONDITIONAL(XENCTRL, test x$xenctrl = xtrue)

libvirt=false @@ -79,7 +79,7 @@ AC_ARG_WITH([xenstore], yes) with_xenstore=true;; no) with_xenstore=false;; *) AC_MSG_ERROR(bad value ${withval} for --with-xenstore) ;; - esac],[with_xenstore=true]) + esac],[AC_CHECK_HEADER(xs.h, with_xenstore=true)]) AM_CONDITIONAL(WITH_XENSTORE, test x$with_xenstore = xtrue)

AC_OUTPUT(vhostmd/Makefile

Thanks, I've applied this. While testing on xen4.1, I noticed the code no longer compiles when xenctrl.h is available. But that is due to a change in the type returned by xc_interface_open(), not related to your patch. Regards, Jim -- To unsubscribe, e-mail: vhostmd+unsubscribe@opensuse.org To contact the owner, e-mail: vhostmd+owner@opensuse.org