openSUSE:Factory:Staging:adi:1 contains packages that use rich deps syntax which confuse the installcheck tool which intern causes repo-checker to spit out an error. This error would have caused the previous repo-checker to silently crash and accept the review. :) Running repo-checker on a Tumbleweed machine results in a pass, but on the packagelists machine results in a failure.
The difference appears to be libsolv-tools:
Tumbleweed = 0.6.28 SLE-12-SP2 = 0.6.26
The resulting error:
could not add repo /tmp/repochecker-iewAELU/packages: susetags: line 5466484: unknown relation: 'if'
It seems the most straightforward approach would be to use a newer version libsolv on the machine. SLE-12-SP3 provides libsolv-0.6.27 which seems to handle the syntax when run in a test container. As such the best solution is likely to update the machine to SP3.
On a more general note this is likely to reoccur when new features are introduced into rpm and used in Factory as the packagelists machine will always be using trailing versions of libsolv. As such it might make more sense to run the repo-checker within a docker container running the latest Tumbleweed snapshot to ensure access to the latest underlying tooling. Any opinions on doing this? I'll file an issue in osc-plugin-factory to track discussion.
With the rpm package built that contains the repo-checker it should not be hard to run things in a docker container.
What is the workflow for updating the packagelists machine?