On Tue, Mar 24, 2009 at 2:39 PM, Michael Cree
On Tue, Mar 24, 2009 at 1:57 PM, Michael Cree
wrote: I attach a patch to modify the _RHDRegRead() and _RHDRegWrite() functions (and their debug versions) to use the MMIO macros provided by the compiler.h header file.
On 25/03/2009, at 10:20 AM, Conn Clark wrote:
It would be better if you also redefined the RHDRegRead and RHDRegWrite macros in rhd.h to do the same thing. This would allow the compiler to inline the instructions instead of calling a function.
True. Admittedly this patch was the easiest approach to get the radeonhd driver to work on other architectures, and was done because I was too lazy to look through to see where the global variable used in _RHDRegRead(), etc., was defined and whether it is available throughout the code.
I'll send you the two macros I wrote to make it easier for you to modify them when I get home.
If the radeonhd developers indicate that they are prepared to merge such patches then I am happy to spend more time on writing a new patch that redefines the macro definitions in rhd.h.
BTW, top-posting is generally frowned upon in these lists (and for good reason!).
Cheers Michael.
And sorry about the top posting. At work here we have a lot of non techies that prefer top posting. I was in top posting mode <blush> Conn -- Conn O. Clark Observation: In formal computer science advances are made by standing on the shoulders of giants. Linux has proved that if there are enough of you, you can advance just as far by stepping on each others toes. -- To unsubscribe, e-mail: radeonhd+unsubscribe@opensuse.org For additional commands, e-mail: radeonhd+help@opensuse.org