On Sat, Mar 29 2003, Peter Osterlund wrote:
On Fri, 28 Mar 2003, M wrote:
I don't suppose anyone has a patch for the latest 2.5 kernel do they?
I do now:
http://w1.894.telia.com/~u89404340/patches/packet/2.5/packet-2.5.66.patch.bz...
What's the status with getting the patch into 2.5?
I have no idea.
A few things that need to be addressed before I can send it to Linus: - scsi_lib.c change, I cannot safely push this change. At some point the request needs to be killed, if it repeatedly returns NOT_READY. I'd recommend we just drop this for now. - relocate_blocks() hook must be dropped for now. - BIO_RW/REQ_RW abuse. Please use bio_data_dir() and rq_data_dir(). - You must not use bio_alloc() for permanent bio allocations! In theory, you could deplete the entire emergency pool this way, the whole kernel io system would break down. - pkt_fixup_segments() is deeply broken, how could this ever work?! You are passing i on the stack, the rest of the logic looks suspicious at best. - pkt_gather_data(), you should use bio_add_page(). this function should probably be rewritten. make-up bio's for the missing segments of a request, and piggy back the original bio to them. when they have all completed, send off the write. - Probably drop the -20 priority from kcdrwd -- Jens Axboe