[opensuse-packaging] Enabled source services
Hi, To avoid suprises on factory checkin, we want to get rid of the "Autobuild autoformatter" script. Actually we want so for ages, but never came around it. So what we now enabled for openSUSE:Factory is a project wide service that will format the spec file at the moment you commit. Newer osc (> 1.131 afaik) will read this service files and use local tools to format the spec files before commit. This osc has been released as update for all openSUSE release for quite some time, so this shouldn't be a problem, but older oscs will simply ignore the fact. Note that this service file applies to all packages linking against openSUSE:Factory. So if you branch from factory, edit something and commit you will get the formating valid for factory. This also means that it's valid to have a different formating in the future, but there will be a check to verify the format follows some guidelines. E.g. it's important to have a copyright/license header. Additionally we enabled the source validator for both osc and the server. So with new osc versions, you will get a local error - if your osc ignores the source service (or you use --skip-local-service-run), the server will put your package in "broken". This source validator has been alive for a while in the form of a osc plugin, so it shouldn't be news. What we did not yet enable is download_files. Adrian would really like to have the source of tars verified, but I think that downloading tar balls locally all the time is bad. So we're looking for the perfect match there yet. AND PLEASE: we enabled these source services to finally go forward with removing these extra steps at checkin, but osc can act at times a little strange with services. So please report bugs and misbehaviours as you see them, I hope we can sort it out for a better world :) Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Hi,
To avoid suprises on factory checkin, we want to get rid of the "Autobuild autoformatter" script. Actually we want so for ages, but never came around it.
So what we now enabled for openSUSE:Factory is a project wide service that will format the spec file at the moment you commit. Newer osc (> 1.131 afaik) will read this service files and use local tools to format the spec files before commit. This osc has been released as update for all openSUSE release for quite some time, so this shouldn't be a problem, but older oscs will simply ignore the fact.
So you removed the autobuild autoformatter and introduced a openSUSE:Factory autoformatter. Which still means we get spurious changes applied each time a package is accepted that has its .spec files auto-generated (like, for example, the various gcc packages). Do I miss something? Richard. -- Richard Guenther <rguenther@suse.de> SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
Am Mittwoch, 7. September 2011 schrieb Richard Guenther:
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Hi,
To avoid suprises on factory checkin, we want to get rid of the "Autobuild autoformatter" script. Actually we want so for ages, but never came around it.
So what we now enabled for openSUSE:Factory is a project wide service that will format the spec file at the moment you commit. Newer osc (> 1.131 afaik) will read this service files and use local tools to format the spec files before commit. This osc has been released as update for all openSUSE release for quite some time, so this shouldn't be a problem, but older oscs will simply ignore the fact.
So you removed the autobuild autoformatter and introduced a openSUSE:Factory autoformatter. Which still means we get spurious changes applied each time a package is accepted that has its .spec files auto-generated (like, for example, the various gcc packages).
Do I miss something?
Yes, you missed to read my mail :) The openSUSE:Factory autoformatter runs "at the moment _you_ commit" (highlighting added). Nothing is formated at acceptenace - but it might be declined if it's not formatted. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Am Mittwoch, 7. September 2011 schrieb Richard Guenther:
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Hi,
To avoid suprises on factory checkin, we want to get rid of the "Autobuild autoformatter" script. Actually we want so for ages, but never came around it.
So what we now enabled for openSUSE:Factory is a project wide service that will format the spec file at the moment you commit. Newer osc (> 1.131 afaik) will read this service files and use local tools to format the spec files before commit. This osc has been released as update for all openSUSE release for quite some time, so this shouldn't be a problem, but older oscs will simply ignore the fact.
So you removed the autobuild autoformatter and introduced a openSUSE:Factory autoformatter. Which still means we get spurious changes applied each time a package is accepted that has its .spec files auto-generated (like, for example, the various gcc packages).
Do I miss something?
Yes, you missed to read my mail :)
The openSUSE:Factory autoformatter runs "at the moment _you_ commit" (highlighting added). Nothing is formated at acceptenace - but it might be declined if it's not formatted.
When I commit it to devel:gcc? So I inherit that openSUSE:Factory source service? I guess I'll see what happens when I "use" it the first time. Thanks, Richard. -- Richard Guenther <rguenther@suse.de> SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
Am Mittwoch, 7. September 2011, 16:18:59 schrieb Richard Guenther:
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Am Mittwoch, 7. September 2011 schrieb Richard Guenther:
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Hi,
To avoid suprises on factory checkin, we want to get rid of the "Autobuild autoformatter" script. Actually we want so for ages, but never came around it.
So what we now enabled for openSUSE:Factory is a project wide service that will format the spec file at the moment you commit. Newer osc (> 1.131 afaik) will read this service files and use local tools to format the spec files before commit. This osc has been released as update for all openSUSE release for quite some time, so this shouldn't be a problem, but older oscs will simply ignore the fact.
So you removed the autobuild autoformatter and introduced a openSUSE:Factory autoformatter. Which still means we get spurious changes applied each time a package is accepted that has its .spec files auto-generated (like, for example, the various gcc packages).
Do I miss something?
Yes, you missed to read my mail :)
The openSUSE:Factory autoformatter runs "at the moment _you_ commit" (highlighting added). Nothing is formated at acceptenace - but it might be declined if it's not formatted.
When I commit it to devel:gcc? So I inherit that openSUSE:Factory source service?
Yes, when your package is a branch from the openSUSE:Factory package.
I guess I'll see what happens when I "use" it the first time.
Thanks, Richard. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Am Mittwoch, 7. September 2011, 16:02:36 schrieb Richard Guenther:
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Hi,
To avoid suprises on factory checkin, we want to get rid of the "Autobuild autoformatter" script. Actually we want so for ages, but never came around it.
So what we now enabled for openSUSE:Factory is a project wide service that will format the spec file at the moment you commit. Newer osc (> 1.131 afaik) will read this service files and use local tools to format the spec files before commit. This osc has been released as update for all openSUSE release for quite some time, so this shouldn't be a problem, but older oscs will simply ignore the fact.
So you removed the autobuild autoformatter and introduced a openSUSE:Factory autoformatter. Which still means we get spurious changes applied each time a package is accepted that has its .spec files auto-generated (like, for example, the various gcc packages).
Do I miss something?
it runs right now ONLY when using osc, so before "osc build" or "osc ci". We may enable it also on the server to enforce the usage later on. But given that you would have the same formater installed, it would just verify that no change is needed.
Richard. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (3)
-
Adrian Schröter -
Richard Guenther -
Stephan Kulow