On Wed, 7 Sep 2011, Stephan Kulow wrote:
Am Mittwoch, 7. September 2011 schrieb Richard Guenther:
On Wed, 7 Sep 2011, Stephan Kulow wrote:
Hi,
To avoid suprises on factory checkin, we want to get rid of the "Autobuild autoformatter" script. Actually we want so for ages, but never came around it.
So what we now enabled for openSUSE:Factory is a project wide service that will format the spec file at the moment you commit. Newer osc (> 1.131 afaik) will read this service files and use local tools to format the spec files before commit. This osc has been released as update for all openSUSE release for quite some time, so this shouldn't be a problem, but older oscs will simply ignore the fact.
So you removed the autobuild autoformatter and introduced a openSUSE:Factory autoformatter. Which still means we get spurious changes applied each time a package is accepted that has its .spec files auto-generated (like, for example, the various gcc packages).
Do I miss something?
Yes, you missed to read my mail :)
The openSUSE:Factory autoformatter runs "at the moment _you_ commit" (highlighting added). Nothing is formated at acceptenace - but it might be declined if it's not formatted.
When I commit it to devel:gcc? So I inherit that openSUSE:Factory
source service?
I guess I'll see what happens when I "use" it the first time.
Thanks,
Richard.
--
Richard Guenther