[opensuse-packaging] Re: [sle-desktop] Autotools version mismatch in GNOME on SLE12-SP2 and Leap 42.2

Felix Zhang

10 Mar 2017 10 Mar '17

08:45

Hi Yifan, Thanks very much for this advice. On a second thought, this issue potentially affects an amount of packages on Leap 42.2. So cross-posting to opensuse-packaging@opensuse.org. Thanks, Felix On 2017/3/7 11:36, Yifan Jiang wrote:

...

Hi Felix,

I guess "research" is also a good place to append the question, making it visible to OBS and toolchain guys :-)

- Yifan

On Mon, Mar 06, 2017 at 09:20:10PM +0800, Felix Zhang wrote:

...
Hi all,

I noticed that the autotools files in our GNOME packages are generated by autotools 1.15. As I didn't find these files included in the upstream repos. I guess they come from openSUSE:Factory at the time we constructed SLE12-SP2 and Leap 42.2.

However, on SP2 and 42.2 we kept autotools 1.13 from updating to 1.15.

This mismatch hit me when I was trying to backport CVE patches for gtk-vnc (bsc#1024266, bsc#1024268) which have modifications on a Makefile.am thus automake is required to regenerate Makefile.in - a build time error complained that automake-1.15 is not found:

https://build.suse.de/package/live_build_log/home:zhangxiaofei:branches:Deve...

I understand there must be good reasons not updating autotools. So my question is, what's a good way to get around such failures please?

Thanks very much in advance for your tips. :-)

Best regards,

Felix

Attachments:

signature.asc (application/pgp-signature — 819 bytes)

Show replies by date

Olaf Hering

10 Mar 10 Mar

09:05

Am Fri, 10 Mar 2017 16:45:55 +0800 schrieb Felix Zhang :

...

...
...
I understand there must be good reasons not updating autotools. So my question is, what's a good way to get around such failures please?

Always run 'autoreconf -fi' before running %configure, there is nothing wrong with that. And if one patches configure.ac or Makefile.am anyway its unavoidable. Olaf

Dimstar / Dominique Leuenberger

13 Mar 13 Mar

14:55

On Fri, 2017-03-10 at 10:05 +0100, Olaf Hering wrote:

...

Am Fri, 10 Mar 2017 16:45:55 +0800 schrieb Felix Zhang :

...
...
...
I understand there must be good reasons not updating autotools. So my question is, what's a good way to get around such failures please?

Always run 'autoreconf -fi' before running %configure, there is nothing wrong with that. And if one patches configure.ac or Makefile.am anyway its unavoidable.

Always? I'd only do it if needed - so if you patch either configure.ac or any of the Makefile.am files. It requires a larger stack in the Buildrequires (automake, autoconf, libtool) and in some cases even more - hence, 'always' running autpreconf does not appear like a sound advise. If you meant to write to always call it when the buildsystem is being changed, then yes: do not rely on configure's built-in detection of the need. Cheers, Dominique -- Dimstar / Dominique Leuenberger

Olaf Hering

15:39

Am Mon, 13 Mar 2017 15:55:31 +0100 schrieb Dimstar / Dominique Leuenberger :

...

Always? I'd only do it if needed - so if you patch either configure.ac or any of the Makefile.am files.

As a former maintainer for a non-i386 arch I can tell that many provided "configure" files are outdated for ports to new non-i386. So yes, run autoreconf -fi unconditionally.

...

It requires a larger stack in the Buildrequires (automake, autoconf, libtool) and in some cases even more - hence, 'always' running autpreconf does not appear like a sound advise.

Since Leap or SLE is built just once there is little overhead. It may cost a few more minutes towards GA. Olaf

Jan Engelhardt

18:52

On Monday 2017-03-13 16:39, Olaf Hering wrote:

...

Am Mon, 13 Mar 2017 15:55:31 +0100 schrieb Dimstar / Dominique Leuenberger :

...
Always? I'd only do it if needed - so if you patch either configure.ac or any of the Makefile.am files.

As a former maintainer for a non-i386 arch I can tell that many provided "configure" files are outdated for ports to new non-i386. So yes, run autoreconf -fi unconditionally.

As a former maintainer for a non-i386 arch I can tell that it is not that bad. It only affects architectures / config tuples that are "new" on the market. If the Chinese make a new MIPS chances are most software already knows about --host=mips-*-*. But... we used to have a %suse_update_config_files (or whatever it was called), and - I may be mistaken - think it was also used to replace just config.guess exactly so that you did not have to rerun autoreconf. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Olaf Hering

19:26

Am Mon, 13 Mar 2017 19:52:25 +0100 (CET) schrieb Jan Engelhardt :

...

As a former maintainer for a non-i386 arch I can tell that it is not that bad. It only affects architectures / config tuples that are "new" on the market.

Thanks Jan. I likely forgot details about the bugs that had to be fixed.. Olaf

Martin Pluskal

10 Mar 10 Mar

09:10

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Fri, 2017-03-10 at 16:45 +0800, Felix Zhang wrote:

...

Hi Yifan,

Thanks very much for this advice. On a second thought, this issue potentially affects an amount of packages on Leap 42.2. So cross- posting to opensuse-packaging@opensuse.org.

Thanks,

Felix

On 2017/3/7 11:36, Yifan Jiang wrote:

...
Hi Felix,

I guess "research" is also a good place to append the question, making it visible to OBS and toolchain guys :-)

- Yifan

On Mon, Mar 06, 2017 at 09:20:10PM +0800, Felix Zhang wrote:

...
Hi all,

I noticed that the autotools files in our GNOME packages are generated by autotools 1.15. As I didn't find these files included in the upstream repos. I guess they come from openSUSE:Factory at the time we constructed SLE12-SP2 and Leap 42.2.

However, on SP2 and 42.2 we kept autotools 1.13 from updating to 1.15.

This mismatch hit me when I was trying to backport CVE patches for gtk-vnc (bsc#1024266, bsc#1024268) which have modifications on a Makefile.am thus automake is required to regenerate Makefile.in - a build time error complained that automake-1.15 is not found:

https://build.suse.de/package/live_build_log/home:zhangxiaofei:br anches:Devel:Desktop:SLE12:SP2/gtk-vnc/standard/x86_64

I understand there must be good reasons not updating autotools. So my question is, what's a good way to get around such failures please?

Thanks very much in advance for your tips. :-)

Best regards,

Felix

Hello

Just add "autoreconf -fiv" before %configure Cheers Martin -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwQnJ+Ps8HqIKhK3yWyRdZ/3eaFcFAljCbXwACgkQWyRdZ/3e aFe5kw//aWF9onuNMOuhNCt7Yl17x7XfKP0Jn5endVr77ZkXwNaoeq7XVDD0drAs lwOciZLn44PUOCT6IkrJGha7H1x8Ik8qpM88uXlTDHl4iKORUCp6mtn8NgJqX8QH 2vAacsWTBTV+j9yUO4ihZ7MvcnaU/jH5gfQJZqBmZpT2CkoxekgJQDwqYtJcSI6M D1Sc8y6BtgUcLG3twauUWDJDJKqBj2ehhiBAI8Auo5G/XsFxhdU2BkYmwhN/WN66 j0InInaF9Dwhc8wll+PrAA9hArJPVyq2V6v6OFxD4F8E6b27mlwNgGHDJksbJQdJ vl9gRlXFRRUDLn8boQzuCs7cxrJzfV1f0YUanF4o0JlS+feMGqdxze4KX3Rn5+HP UaAwlabRmN28IaPj78xHLSGY7O6FsxoBbLFEOh7wAjaDckHo5daZx1M1my1L5Qhj S+zl/h7xPJni45VGNhxqBwZRPYkpCQDeyrq3UuOvNLrFXsEreqTDN6N0sg5fpQAm I4LsYyZU5++DHU80vebDefyPmrcjsZ60/fQ47X9LMKB52JGQq6hLU9pmu98QubpC k0VLHhIYsm12OO7mFZUa0DxCzvO3s2yY0mj4yPKl1Rzo5hgU5FVnrQScOkRfAO2E TG7XGHfc6/ae23Bmd+gp8Z+VuqBpWkPBpnaA+MV8d9mZW0YPLsc= =8ONi -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

Felix Zhang

11 Mar 11 Mar

11:10

Hi Martin, Olaf, On 2017/3/10 17:10, Martin Pluskal wrote:

...

On Fri, 2017-03-10 at 16:45 +0800, Felix Zhang wrote:

...
Hi Yifan,

...
Thanks very much for this advice. On a second thought, this issue potentially affects an amount of packages on Leap 42.2. So cross- posting to opensuse-packaging@opensuse.org.

...
Thanks,

...
Felix

...
On 2017/3/7 11:36, Yifan Jiang wrote:

...
Hi Felix,

I guess "research" is also a good place to append the question, making it visible to OBS and toolchain guys :-)

- Yifan

On Mon, Mar 06, 2017 at 09:20:10PM +0800, Felix Zhang wrote:

...
Hi all,

I noticed that the autotools files in our GNOME packages are generated by autotools 1.15. As I didn't find these files included in the upstream repos. I guess they come from openSUSE:Factory at the time we constructed SLE12-SP2 and Leap 42.2.

However, on SP2 and 42.2 we kept autotools 1.13 from updating to 1.15.

This mismatch hit me when I was trying to backport CVE patches for gtk-vnc (bsc#1024266, bsc#1024268) which have modifications on a Makefile.am thus automake is required to regenerate Makefile.in - a build time error complained that automake-1.15 is not found:

https://build.suse.de/package/live_build_log/home:zhangxiaofei:br anches:Devel:Desktop:SLE12:SP2/gtk-vnc/standard/x86_64

I understand there must be good reasons not updating autotools. So my question is, what's a good way to get around such failures please?

Thanks very much in advance for your tips. :-)

Best regards,

Felix

Hello

Just add "autoreconf -fiv" before %configure

Cheers

Martin

Sorry for the late reply. Will remember to do that. Thank you very much for the hint. :-) Best regards, Felix

2606

Age (days ago)

2609

Last active (days ago)

List overview

Download

7 comments

5 participants

participants (5)

Dimstar / Dominique Leuenberger
Felix Zhang
Jan Engelhardt
Martin Pluskal
Olaf Hering