[opensuse-packaging] Help packaging a new app using vala
Hi I'm having some trouble building Tracker a desktop neutral application. Build fails with the following message: I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: tracker voidreturn tracker-turtle-reader.c:307 I: Program returns random data in a function E: tracker no-return-in-nonvoid-function tracker-sparql-query.c:884, 4775, 5430, 8305, 1197 E: tracker no-return-in-nonvoid-function tracker-turtle-reader.c:460 But in fact these files are generated by valac, the vala -> C "compiler" which means this files don't exist on the source tarball. The spec file and the full build is available on home:lmedinas/tracker Any guess how i can fix this ? Thanks Luis -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 20/01/10 23:10, Luis Medinas wrote:
Hi
I'm having some trouble building Tracker a desktop neutral application.
Build fails with the following message:
I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: tracker voidreturn tracker-turtle-reader.c:307
I: Program returns random data in a function E: tracker no-return-in-nonvoid-function tracker-sparql-query.c:884, 4775, 5430, 8305, 1197 E: tracker no-return-in-nonvoid-function tracker-turtle-reader.c:460
Any guess how i can fix this ?
open a bug report at vala's developer site, it seems to gnerate buggy code... -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Wed, 2010-01-20 at 23:52 -0300, Cristian Rodríguez wrote:
On 20/01/10 23:10, Luis Medinas wrote:
Hi
I'm having some trouble building Tracker a desktop neutral application.
Build fails with the following message:
I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: tracker voidreturn tracker-turtle-reader.c:307
I: Program returns random data in a function E: tracker no-return-in-nonvoid-function tracker-sparql-query.c:884, 4775, 5430, 8305, 1197 E: tracker no-return-in-nonvoid-function tracker-turtle-reader.c:460
Any guess how i can fix this ?
open a bug report at vala's developer site, it seems to gnerate buggy code...
There's already an open bug reported from the GNOME team. https://bugzilla.gnome.org/show_bug.cgi?id=589942 Luis -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Le mercredi 20 janvier 2010, à 23:52 -0300, Cristian Rodríguez a écrit :
On 20/01/10 23:10, Luis Medinas wrote:
Hi
I'm having some trouble building Tracker a desktop neutral application.
Build fails with the following message:
I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: tracker voidreturn tracker-turtle-reader.c:307
I: Program returns random data in a function E: tracker no-return-in-nonvoid-function tracker-sparql-query.c:884, 4775, 5430, 8305, 1197 E: tracker no-return-in-nonvoid-function tracker-turtle-reader.c:460
Any guess how i can fix this ?
open a bug report at vala's developer site, it seems to gnerate buggy code...
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached. And we're back to the question: how can we ignore the rpmlint errors to get the packaging done? Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, Jan 21, 2010 at 11:27:27AM +0100, Vincent Untz wrote:
Le mercredi 20 janvier 2010, à 23:52 -0300, Cristian Rodríguez a écrit :
On 20/01/10 23:10, Luis Medinas wrote:
Hi
I'm having some trouble building Tracker a desktop neutral application.
Build fails with the following message:
I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: tracker voidreturn tracker-turtle-reader.c:307
I: Program returns random data in a function E: tracker no-return-in-nonvoid-function tracker-sparql-query.c:884, 4775, 5430, 8305, 1197 E: tracker no-return-in-nonvoid-function tracker-turtle-reader.c:460
Any guess how i can fix this ?
open a bug report at vala's developer site, it seems to gnerate buggy code...
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached. And we're back to the question: how can we ignore the rpmlint errors to get the packaging done?
You fix the code. Which buildservice repo does it live in, then I can do a patch for review? Ciao, Marcus -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Am Donnerstag, 21. Januar 2010 schrieb Vincent Untz:
Le mercredi 20 janvier 2010, à 23:52 -0300, Cristian Rodríguez a écrit :
On 20/01/10 23:10, Luis Medinas wrote:
Hi
I'm having some trouble building Tracker a desktop neutral application.
Build fails with the following message:
I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: tracker voidreturn tracker-turtle-reader.c:307
I: Program returns random data in a function E: tracker no-return-in-nonvoid-function tracker-sparql-query.c:884, 4775, 5430, 8305, 1197 E: tracker no-return-in-nonvoid-function tracker-turtle-reader.c:460
Any guess how i can fix this ?
open a bug report at vala's developer site, it seems to gnerate buggy code...
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached. And we're back to the question: how can we ignore the rpmlint errors to get the packaging done?
dirty hack: as rpmlint is checking the output of the compiler .... hide it :) make 2> /dev/null
Vincent
-- Les gens heureux ne sont pas pressés.
-- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Le jeudi 21 janvier 2010, à 11:34 +0100, Marcus Meissner a écrit :
On Thu, Jan 21, 2010 at 11:27:27AM +0100, Vincent Untz wrote:
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached. And we're back to the question: how can we ignore the rpmlint errors to get the packaging done?
You fix the code.
But the C code is generated during the build.
Which buildservice repo does it live in, then I can do a patch for review?
home:lmedinas/tracker Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On 21/01/10 07:27, Vincent Untz wrote:
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached.
But it produces undefined behaviour anyway, the code generator should be fixed to return something. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, Jan 21, 2010 at 11:45:01AM +0100, oc2pus@arcor.de wrote:
Am Donnerstag, 21. Januar 2010 schrieb Vincent Untz:
Le mercredi 20 janvier 2010, à 23:52 -0300, Cristian Rodríguez a écrit :
On 20/01/10 23:10, Luis Medinas wrote:
Hi
I'm having some trouble building Tracker a desktop neutral application.
Build fails with the following message:
I: A function uses a 'return;' statement, but has actually a value to return, like an integer ('return 42;') or similar. W: tracker voidreturn tracker-turtle-reader.c:307
I: Program returns random data in a function E: tracker no-return-in-nonvoid-function tracker-sparql-query.c:884, 4775, 5430, 8305, 1197 E: tracker no-return-in-nonvoid-function tracker-turtle-reader.c:460
Any guess how i can fix this ?
open a bug report at vala's developer site, it seems to gnerate buggy code...
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached. And we're back to the question: how can we ignore the rpmlint errors to get the packaging done?
dirty hack: as rpmlint is checking the output of the compiler .... hide it :) make 2> /dev/null
Never ever do this. Ciao, Marcus -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
Le jeudi 21 janvier 2010, à 09:39 -0300, Cristian Rodríguez a écrit :
On 21/01/10 07:27, Vincent Untz wrote:
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached.
But it produces undefined behaviour anyway, the code generator should be fixed to return something.
How can it produce undefined behavior if it's never reached? And I'm not saying the code generator should not be fixed; it's just a problem that upstream doesn't consider urgent for now, so it's not getting fixed. This upstream issue combined with the rpmlint error is blocking the build. If we can either fix the upstream issue or ignore the rpmlint error, then everything will be fine for the build. And the ignoring rpmlint is much easier for now (assuming, again, that we can trust upstream on this). Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
On Thu, Jan 21, 2010 at 01:49:01PM +0100, Vincent Untz wrote:
Le jeudi 21 janvier 2010, à 09:39 -0300, Cristian Rodríguez a écrit :
On 21/01/10 07:27, Vincent Untz wrote:
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached.
But it produces undefined behaviour anyway, the code generator should be fixed to return something.
How can it produce undefined behavior if it's never reached?
And I'm not saying the code generator should not be fixed; it's just a problem that upstream doesn't consider urgent for now, so it's not getting fixed. This upstream issue combined with the rpmlint error is blocking the build. If we can either fix the upstream issue or ignore the rpmlint error, then everything will be fine for the build. And the ignoring rpmlint is much easier for now (assuming, again, that we can trust upstream on this).
Well, it has exit nodes in functions which can happen under out of memory or other error situations. If those cannot happen then the previous if() is unnecessary. And one issue is a true bug (the one marked as W). Patch would be this, also submitreqed. Ciao, Marcus Index: src/libtracker-data/tracker-sparql-query.c =================================================================== --- src/libtracker-data/tracker-sparql-query.c.orig +++ src/libtracker-data/tracker-sparql-query.c @@ -881,6 +881,7 @@ static gboolean tracker_sparql_query_exp return FALSE; } } + return FALSE; } @@ -1194,6 +1195,7 @@ TrackerDBResultSet* tracker_sparql_query } } } + return NULL; } @@ -4772,6 +4774,7 @@ static char* tracker_sparql_query_parse_ } } } + return NULL; } @@ -5427,6 +5430,7 @@ static TrackerPropertyType tracker_sparq } } } + return 0; } @@ -8302,6 +8306,7 @@ static gboolean tracker_sparql_query_is_ g_clear_error (&_inner_error_); return FALSE; } + return FALSE; } Index: src/libtracker-data/tracker-turtle-reader.c =================================================================== --- src/libtracker-data/tracker-turtle-reader.c.orig +++ src/libtracker-data/tracker-turtle-reader.c @@ -304,7 +304,7 @@ TrackerTurtleReader* tracker_turtle_read if (_inner_error_ != NULL) { if (_inner_error_->domain == G_FILE_ERROR) { g_propagate_error (error, _inner_error_); - return; + return NULL; } else { g_critical ("file %s: line %d: uncaught error: %s", __FILE__, __LINE__, _inner_error_->message); g_clear_error (&_inner_error_); @@ -457,6 +457,7 @@ static gboolean tracker_turtle_reader_ex return FALSE; } } + return FALSE; } -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org
participants (5)
-
Cristian Rodríguez -
Luis Medinas -
Marcus Meissner -
oc2pus＠arcor.de -
Vincent Untz