On Thu, Jan 21, 2010 at 01:49:01PM +0100, Vincent Untz wrote:
Le jeudi 21 janvier 2010, à 09:39 -0300, Cristian Rodríguez a écrit :
On 21/01/10 07:27, Vincent Untz wrote:
So, assuming upstream developers are right in the bug linked by Luis, the code with no-return-in-nonvoid-function will not be reached.
But it produces undefined behaviour anyway, the code generator should be fixed to return something.
How can it produce undefined behavior if it's never reached?
And I'm not saying the code generator should not be fixed; it's just a problem that upstream doesn't consider urgent for now, so it's not getting fixed. This upstream issue combined with the rpmlint error is blocking the build. If we can either fix the upstream issue or ignore the rpmlint error, then everything will be fine for the build. And the ignoring rpmlint is much easier for now (assuming, again, that we can trust upstream on this).
Well, it has exit nodes in functions which can happen under out of memory or other error situations. If those cannot happen then the previous if() is unnecessary. And one issue is a true bug (the one marked as W). Patch would be this, also submitreqed. Ciao, Marcus Index: src/libtracker-data/tracker-sparql-query.c =================================================================== --- src/libtracker-data/tracker-sparql-query.c.orig +++ src/libtracker-data/tracker-sparql-query.c @@ -881,6 +881,7 @@ static gboolean tracker_sparql_query_exp return FALSE; } } + return FALSE; } @@ -1194,6 +1195,7 @@ TrackerDBResultSet* tracker_sparql_query } } } + return NULL; } @@ -4772,6 +4774,7 @@ static char* tracker_sparql_query_parse_ } } } + return NULL; } @@ -5427,6 +5430,7 @@ static TrackerPropertyType tracker_sparq } } } + return 0; } @@ -8302,6 +8306,7 @@ static gboolean tracker_sparql_query_is_ g_clear_error (&_inner_error_); return FALSE; } + return FALSE; } Index: src/libtracker-data/tracker-turtle-reader.c =================================================================== --- src/libtracker-data/tracker-turtle-reader.c.orig +++ src/libtracker-data/tracker-turtle-reader.c @@ -304,7 +304,7 @@ TrackerTurtleReader* tracker_turtle_read if (_inner_error_ != NULL) { if (_inner_error_->domain == G_FILE_ERROR) { g_propagate_error (error, _inner_error_); - return; + return NULL; } else { g_critical ("file %s: line %d: uncaught error: %s", __FILE__, __LINE__, _inner_error_->message); g_clear_error (&_inner_error_); @@ -457,6 +457,7 @@ static gboolean tracker_turtle_reader_ex return FALSE; } } + return FALSE; } -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org