[opensuse-packaging] rpmlint-checks: adding new gnome/desktop-related checks

older
[opensuse-packaging] Buildrequires...

Vincent Untz

8 Oct 2010 8 Oct '10

14:30

Hi, I've been adding some macros to make life easier when packaging things for GNOME, or desktop applications in general. See [1] for some of those, and I guess I'll send a new mail later for the others -- I just need to figure out where some of them should live. Anyway. The thing is that those macros are all nice, but nobody will think about using them if they don't have rpmlint checks. So I wrote some checks. Can we add this to the rpmlint-checks git repo, and to our rpmlint package? Thanks, Vincent [1] http://lists.opensuse.org/opensuse-packaging/2010-08/msg00059.html -- Les gens heureux ne sont pas pressés.

Attachments:

CheckGNOMEMacros.py (text/x-python — 7.8 KB)

Show replies by date

Cristian Morales Vega

8 Oct 8 Oct

16:57

2010/10/8 Vincent Untz :

...

Hi,

I've been adding some macros to make life easier when packaging things for GNOME, or desktop applications in general. See [1] for some of those, and I guess I'll send a new mail later for the others -- I just need to figure out where some of them should live.

Anyway. The thing is that those macros are all nice, but nobody will think about using them if they don't have rpmlint checks. So I wrote some checks.

Can we add this to the rpmlint-checks git repo, and to our rpmlint package?

Thanks,

Vincent

[1] http://lists.opensuse.org/opensuse-packaging/2010-08/msg00059.html

As discussed at http://lists.opensuse.org/opensuse-packaging/2010-08/msg00017.html the installer's people don't really like gtk-update-icon-cache, have you talked with Lukas Ocilka? And shouldn't the %desktop_database_* checks check for MimeType entries in the desktop files before complaining? It's my understanding that update-desktop-database does nothing if there are no MimeType entries. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Vincent Untz

18:23

Le vendredi 08 octobre 2010, à 18:57 +0200, Cristian Morales Vega a écrit :

...

2010/10/8 Vincent Untz :

...
Anyway. The thing is that those macros are all nice, but nobody will think about using them if they don't have rpmlint checks. So I wrote some checks.

[...]

...

As discussed at http://lists.opensuse.org/opensuse-packaging/2010-08/msg00017.html the installer's people don't really like gtk-update-icon-cache, have you talked with Lukas Ocilka?

I didn't have time yet. FWIW, we can find a better solution later: it's a macro, so we'll be able to change it in one place if we find something better.

...

And shouldn't the %desktop_database_* checks check for MimeType entries in the desktop files before complaining? It's my understanding that update-desktop-database does nothing if there are no MimeType entries.

Right. I was wondering if it was worth it. But since it's not hard to do... Updated checks attached. Vincent -- Les gens heureux ne sont pas pressés.

Cristian Morales Vega

23:04

2010/10/8 Vincent Untz :

...

Le vendredi 08 octobre 2010, à 18:57 +0200, Cristian Morales Vega a écrit :

...
As discussed at http://lists.opensuse.org/opensuse-packaging/2010-08/msg00017.html the installer's people don't really like gtk-update-icon-cache, have you talked with Lukas Ocilka?

I didn't have time yet. FWIW, we can find a better solution later: it's a macro, so we'll be able to change it in one place if we find something better.

This should be really be talked with whoever is the "RPM man" in openSUSE. What's the status of file triggers? Googling "file triggers site:lists.rpm.org" it seems nobody is working in them. But there was that "Collections" thing not too long ago. In fact I would really like a "RPM status report" from time to time. I would be tempted to think RPM development is still slow, nearly dead... until I see the GIT log and see it's actually very active! I'm sure we are not using things provided by new RPM versions only because we don't know about them. I just looked in my 11.3 system... why is ping still using SUID instead of file capabilities? (just saw them in the RPM's GIT log) Mandriva has a file triggers patch, true? I'm sure it isn't in upstream RPM because their implementation has some problems... but are those problems worse than the ones we face when calling gtk-update-icon-cache and some others from every package? If we use that patch, once an official solution is there the spec files will need to be changed?

...

...
And shouldn't the %desktop_database_* checks check for MimeType entries in the desktop files before complaining? It's my understanding that update-desktop-database does nothing if there are no MimeType entries.

Right. I was wondering if it was worth it. But since it's not hard to do... Updated checks attached.

It would be nice to comment the MimeType entries thing in the error message. But otherwise, without knowing a thing about all those GTK/GDK/GNOME/GLIB things, the macros seem an improvement to me. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Cristian Morales Vega

16 Jan 16 Jan

18:21

2010/10/8 Vincent Untz :

...

Le vendredi 08 octobre 2010, à 18:57 +0200, Cristian Morales Vega a écrit :

...
2010/10/8 Vincent Untz :

...
Anyway. The thing is that those macros are all nice, but nobody will think about using them if they don't have rpmlint checks. So I wrote some checks.

[...]

...
As discussed at http://lists.opensuse.org/opensuse-packaging/2010-08/msg00017.html the installer's people don't really like gtk-update-icon-cache, have you talked with Lukas Ocilka?

I didn't have time yet. FWIW, we can find a better solution later: it's a macro, so we'll be able to change it in one place if we find something better.

So, what's the final decision? We are at two months from 11.4 release and the status in Factory seems to be: - SuSEconfig.gtk2 has been removed - rpmlint doesn't complain about packages with icons not running %icon_theme_cache_post So nothing is running gtk-update-icon-cache, whatever you install from zypper or YaST. I have not seen the %icon_theme_cache_post macro used even in the GNOME:Factory packages. What should I do with my packages that install icons? -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Cristian Morales Vega

18:44

2011/1/16 Cristian Morales Vega :

...

2010/10/8 Vincent Untz :

...
Le vendredi 08 octobre 2010, à 18:57 +0200, Cristian Morales Vega a écrit :

...
2010/10/8 Vincent Untz :

...
Anyway. The thing is that those macros are all nice, but nobody will think about using them if they don't have rpmlint checks. So I wrote some checks.

[...]

...
As discussed at http://lists.opensuse.org/opensuse-packaging/2010-08/msg00017.html the installer's people don't really like gtk-update-icon-cache, have you talked with Lukas Ocilka?

I didn't have time yet. FWIW, we can find a better solution later: it's a macro, so we'll be able to change it in one place if we find something better.

So, what's the final decision? We are at two months from 11.4 release and the status in Factory seems to be: - SuSEconfig.gtk2 has been removed - rpmlint doesn't complain about packages with icons not running %icon_theme_cache_post

So nothing is running gtk-update-icon-cache, whatever you install from zypper or YaST. I have not seen the %icon_theme_cache_post macro used even in the GNOME:Factory packages. What should I do with my packages that install icons?

FWIW, if instead of calling gtk-update-icon-cache on each package installation you change the %icon_theme_cache_post(un) macros to use ZYpp's update-scripts (http://lists.opensuse.org/zypp-devel/2010-06/msg00005.html) you have my vote to add those checks today. That should solve any problem with the installer. Michael, are update-scripts still the best way to run something that needs to be done for a lot of packages and it is enough if it's run once after all packages have been installed (ldconfig doesn't applies)? Or there is something new in the RPM version from 11.4 ("Collections", file triggers or whatever upstream has done recently)? There is any good documentation about update-scripts? -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org

Vincent Untz

17 Jan 17 Jan

10:30

Le dimanche 16 janvier 2011, à 19:21 +0100, Cristian Morales Vega a écrit :

...

So nothing is running gtk-update-icon-cache, whatever you install from zypper or YaST. I have not seen the %icon_theme_cache_post macro used even in the GNOME:Factory packages.

We do have packages using the macros, but we didn't have time to convert everything, true.

...

What should I do with my packages that install icons?

Use the macros. There's one issue with the macro, though: they wrongly assume that, on upgrade, %postun of the old package is called before %post of the new package. To be honest, it shouldn't matter in most cases, and the right fix would imply using a %posttrans instead... On the other hand, if we can use a mechanism to delay the call to gtk-update-icon-cache like you suggest in your later mail, that'd work fine. So let's wait for an answer to your second mail, to know if there's something we can use for this before deciding if we need to add more macros. But in general, yes, please use the macros. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org