Michal Kubecek píše v Po 24. 07. 2017 v 08:19 +0200:
On Wednesday, 19 July 2017 13:32 Simon Lees wrote:
On 19/07/17 20:27, Jan Engelhardt wrote:
On Wednesday 2017-07-19 11:24, Tomas Chvatal wrote:
Well we have replacement in spec-cleaner.
That does not make it better - after all, it's a "pick your poison" kind of choice. s-c may not move comments, but in turn it transmogrifies other things.
But at least when it does you can open a bugreport with a description of what has happened why it shouldn't have happened and then in most cases someone will reply to the bug report and get the issue fixed at some point.
That doesn't help with the basic issue of the tool: it (or rather its author) assumes the is One and Only Right Way to write specfiles. Just for fun, I ran it on one of my specfiles (with -m) and diff-ed the original specfile and the result.
1. Sometimes I want to add an empty line between sections to visually separate them. The tool eats them.
Michal, you were on the OSC and I think you were in the audience of the spec-cleaner talk. I think i mentioned that I wrote switch that allows you to keep your vertical alignment...
2. For specfiles with more patches (say, from ten up), I find it much easier to read and work with if the "Patch*" lines are separated from the rest of the header. The tool moves them right in the middle of it.
That is why we created feature of codeblocks and you can do whatever you fancy with them, even explaned that on the talk...
3. I don't want to write "Url" because it's completely wrong but the tool will "fix" my correct "URL" each time. Create a poll, I don't care what comes out of it. Simply put preferred solution should be one key used for it everywhere.
4. I keep (if-ed) BuildRoot in some of my specfiles because I need them to build on SLE11. The tool started to eat it. Actually, it eats the "BuildRoot" line and leaves an empty %if-%endif section in place. You do realize you can inject the buildroot on projectconfig level and not pollute packages for factory right? Also all these are in code in a way you can introduce new switch like --sle11-compat and keep them enabled, I simply didn't care about sle11 enough anymore.
Also conditionalizing the buildrequires is totally pointless, if you define it to default value it has no effect being there all the time. That empty condition is bug tho, maybe i should put check if there is some content in nested condition and prune it if it gets empty, feel free to report a bug. Tom