On Monday, 24 July 2017 10:24 Tomas Chvatal wrote:
Michal Kubecek píše v Po 24. 07. 2017 v 08:19 +0200:
1. Sometimes I want to add an empty line between sections to
separate them. The tool eats them.
Michal, you were on the OSC and I think you were in the audience of
the spec-cleaner talk. I think i mentioned that I wrote switch that
allows you to keep your vertical alignment...
The only OSC I attended was in Prague back in 2012 (or even 2011),
I doubt you mean that one. I was at your talk about spec-cleaner some
time ago (in SUSE office) but I don't think you mentioned that there
Anyway, there is -k option (--keep-space) but according to --help text,
it only preserves empty lines "in preamble" and, indeed, it only
preserves empty lines up to a certain point in specfile. Even if it did
preserve them in the whole file, there would still be two important
- why are they not preserved by "-m" which, according to
documentation, "does not do anything intrusive (ie. just sets the
- if, one day, spec-cleaner is run automatically on every commit
(instead of current service) which is the plan, IIUC, is this
going to be the default?
specfiles with more patches (say, from ten up), I find it
much easier to read and work with if the "Patch*" lines are
separated from the rest of the header. The tool moves them
right in the middle of it.
That is why we created feature of codeblocks and you can do whatever
you fancy with them, even explaned that on the talk...
OK, I'll look for the documentation on that.
don't want to write "Url" because it's completely wrong but
the tool will "fix" my correct "URL" each time.
Create a poll, I don't care what comes out of it. Simply put preferred
solution should be one key used for it everywhere.
...which is exactly the problem I'm talking about. Moreover, in this
particular case, it would be a bit like creating a poll about what the
result of "2 + 2" is. "URL" is an acronym meaning "Uniform
Locator" and as such, the correct way to write it is "URL", there is no
voting about that.
4. I keep
(if-ed) BuildRoot in some of my specfiles because I need
them to build on SLE11. The tool started to eat it. Actually,
it eats the "BuildRoot" line and leaves an empty %if-%endif
section in place.
You do realize you can inject the buildroot on projectconfig level and
not pollute packages for factory right?
I didn't until now. That may be a solution - except I don't always have
the prjconf under my control.
Also all these are in code in
a way you can introduce new switch like --sle11-compat and keep them
enabled, I simply didn't care about sle11 enough anymore.
Let me say I find this very disturbing, considering SLE11 SP4 is still
under regular support and is going stay so until March 2019.
Also conditionalizing the buildrequires is totally
pointless, if you
define it to default value it has no effect being there all the time.
Even if I define them to what is their default value right now, I can
never know if the value is not going to change at some point. If there
was a way, I would prefer only setting BuildRoot if it's not predefined.
I'm not aware of any.
But I'm afraid this is all missing the point I was trying to make. What
I wanted to say was that current spec-cleaner, even with -m option, is
way to intrusive to be seriously considered a replacement of the OBS
service which is used now. For the record, I'm talking about the version
I tried few hours ago (which is the one from fully updated openSUSE
To unsubscribe, e-mail: opensuse-packaging+unsubscribe(a)opensuse.org
To contact the owner, e-mail: opensuse-packaging+owner(a)opensuse.org