On 07/18/2017 11:14 AM, Michal Srb wrote:
Hi,
I have problem with format_spec_file, it moves comments to different lines for no obvious reason.
For example in SUSE:SLE-12-SP1:Update/tigervnc:
Snipped from original spec file: Url: http://tigervnc.org/ BuildRoot: %{_tmppath}/%{name}-%{version}-build Summary: A high-performance, platform-neutral implementation of VNC License: GPL-2.0 and MIT Group: System/X11/Servers/XF86_4 # would need fixing to use fPIC in common/CMakeLists.txt ExcludeArch: s390 Source1: https://github.com/TigerVNC/tigervnc/archive/v%version}.tar.gz Source3: vnc.xinetd
After format_spec_file: Url: http://tigervnc.org/ BuildRoot: %{_tmppath}/%{name}-%{version}-build Summary: A high-performance, platform-neutral implementation of VNC # would need fixing to use fPIC in common/CMakeLists.txt License: GPL-2.0 and MIT Group: System/X11/Servers/XF86_4 ExcludeArch: s390 Source1: https://github.com/TigerVNC/tigervnc/archive/v%{version}.tar.gz Source3: vnc.xinetd
The comment moved to a different line where it doesn't make sense. Is it a bug in obs-service-format_spec_file?
This detail is probably a bug but actually it's broken by design. There should not be any "plugin" for versioning-control-systems which edits your files silently just *before* you save (commit) it. It's the opposite of the one major thing what any VCS should do: DO NOT LOSE/RANDOMIZE ANY WORK DONE BY THE USER. The best way is to commit always using --noservice. You can also disable the services completely on your systems somehow, don't remember right now how I did it. cu, Rudi -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org