Le mercredi 25 août 2010 à 13:33 +0200, Vincent Untz a écrit :
Le mercredi 25 août 2010, à 13:31 +0200, Frederic Crozat a écrit :
Le mercredi 25 août 2010 à 13:22 +0200, Ludwig Nussel a écrit :
Vincent Untz wrote:
I'm considering patching rpmlint to add errors when those macros are not used. See the attached patch, which I haven't tested yet.
I'm a bit worried that adding tons of checks like this will be expensive in the long term. On the other hand, missing those calls is really bad since it will result in non-working packages or even crashing applications.
There are more expensive tests than those anyways so don't worry. The rpmlint package already carries way too much patches though. If your tests are SUSE specific anyways it would probably make sense to have it in a separate file here: http://gitorious.org/opensuse/rpmlint-checks
If the macros are suse specific I wonder how other distros solve the problem?
With my "previous" Mandriva hat :
macros were used, similar to Vincent proposal, until file triggers were added to Mandriva RPM (I think there is work to add them to upstream RPM too), which was doing the work in the background ;)
Yep, I've kept that in mind: later on, when this will be available, we can make the macros do nothing ;-)
While adding macros for gtk/glib, shouldn't we also add a macro for icon cache regeneration (like in Mandriva) ?
I have macros ready for this. I just don't know where they should live, since gtk2/gtk3 is wrong (you don't want to have all packages with icons depending on gtk2 at build time).
I'd suggest hicolor-icon-theme and ensuring the macro only does
something if gtk-update-icon-cache is installed.
--
Frederic Crozat