On 09/06/2010 at 10:49 AM, Michal Marek
wrote: Burden? Writing a one phrase sentence with references what the next line is about? Later in the thread, there were examples with multiline comments.
There are spec files I'm certainly never going to touch. Having a gazillion of patches in any package is not the right thing to do anyway... this simply does not scale and is a pain when an update
But your proposal makes this even less scalable and more painful. Packages with lots of patches are here to stay, the exercise should be to make their maintenance easier, not the opposite.
Are they??? Isn't the spirit of opensource to bring those patches back upstream? Having a package that is supposed to keep it's patches around just sounds broken.
The tag line is not only for scripts, that's for sure.. but also for other people hacking on your spec files (everybody should be able to touch every package, no?)
I'm not at all convinced that that a preamble interleaved with comments with cryptic tags is more convenient to work with, especially for outsiders. What's the problem with putting any metadata into the patch headers? This is what some other teams are already doing, it is easily extensible and the pairing of patches and metadata is straightforward. Or even better, let each time work the way they think is most efficient for them. I'm also not saying "all packages must have a patches.fixes.tar.bz2 and patches.suse.tar.bz2, this is going to be an autobuild rule starting next week".
Having the comment of the patch in the preamble helps understanding what a patch is for, without switching to all the other 20 files in the folder. Additionally it helps the autobuild team to understand why a patch get's there. Of course I don't expect that autobuild is going to enforce this on team like kernel, which has a complete different approach on patches and a different source control anyway. But that's up to autobuild to decide to whom they feel like granting an exception would make sense. Every good rule has it's exception. Nothing new there. Dominique -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-packaging+help@opensuse.org