On 12/27/18 10:19 PM, Neal Gompa wrote:
On Thu, Dec 27, 2018 at 2:17 PM Michal Rostecki
wrote: On 12/26/18 8:15 PM, Neal Gompa wrote:
The purpose of this check is to ensure that each newest changelog entry mapped to the version-release built of the package. However, openSUSE changelogs are not structured that way, so this particular check has never been satisfied properly. If you look at Fedora or Mageia packages, the changelog entries are structured in such a way that this warning never triggers. The SUSE-style changes format doesn't include enough information for that check to pass post-conversion.Thus, I agree it should be disabled in openSUSE, or at least have a variation of the check that makes more sense.
To be more concrete - rpmlint expects a version in the same line where you have date, time, name and email. Example:
https://src.fedoraproject.org/cgit/rpms/systemd.git/tree/systemd.spec#n691
I agree that this check should be disabled in openSUSE, unless we want to introduce the same format of changelog which Fedora has.
I'm surprised and impressed that someone knows where to look for Fedora packaging sources. I always had the impression that most folks seemed to be ignorant of how it's done in Fedora.
That said, it's technically also supposed to be able to be satisfied by the first line of the changelog text including it, but again, the way openSUSE does packaging and changelogs makes this completely fail anyway.
Could you be more specific? What exactly makes this check fail anyway in openSUSE packages? What's wrong with the structure of specs and changelogs in openSUSE? You mentioned earlier that "SUSE-style changes format doesn't include enough information". What information is missing except the version in the first line of changelog entries? I tried out whether adding version to last changelog entries makes that warning disappear in several openSUSE packages - and indeed it does. I also didn't notice anything else when taking a look at random openSUSE and Fedora rpmspecs. I see that some packages in Fedora also started to include versions at some point, not from the beginning, i.e.: https://src.fedoraproject.org/rpms/emacs/blob/master/f/emacs.spec#_1877 So, in case we decide to keep no-version-in-last-changelog check, fixing it is not a big deal. But yeah, I'm probably "ignorant" and I hope that you are going to enlighten me. -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org