Johannes Meixner writes:
From my point of view it is never ever allowed (even not legally allowed) that an automated tool silently and anonymously modifies sources.
I don't know what you mean by "anonymously" in this context, but I agree with your sentiment about silently re-writing source code before committing it. The fact that the state I commit to the server is not the same state that I see on my hard drive before running "osc commit" is quite unacceptable. osc should verify that running spec-cleaner on the current state is a no-op before allowing me to commit -- i.e. it should guarantee that *I* run spec-cleaner before committing --, but osc should not run spec-cleaner for me. Having said that, I am hugely in favor of enforcing a rule that all spec files must pass through spec-cleaner though, for the following reasons: - All spec files will look basically the same. Attributes are specified in the same order and in the same spelling, which makes it easier to read them. It's also easier to "grep" for things if spelling is uniform. Having a reliable structure simplifies the task of scripting things in general, because stronger assumptions can be made. - When spec files are normalized before committing (like, ensuring that all BuildDepends are ordered alphabetically), then the resulting diffs will be minimal. There won't be any pointless white-space changes obscuring the purpose of the modification. Nor will there be changes that turn the spelling of "Url" into "URL" for no apparent reason. That makes life easier for people who review SRs etc. - If every spec file is known to pass through spec-cleaner, then we can reliably re-run the tool on every spec file to perform mass style updates. A new version of spec-cleaner might, for example, re-write the copyright disclaimer, or it might replace an obsolete attribute with the newer version, or whatever. Once you know that all spec files can be passed through the tool without breaking them, you can use the tool for maintenance tasks that wouldn't be feasible otherwise. Best regards, Peter -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org