11 Jan
2014
11 Jan
'14
16:34
Andrey Borzenkov (arvidjaar@gmail.com) wrote:
В Sat, 11 Jan 2014 08:47:18 +0100 (CET) Jan Engelhardt
пишет: my @args = ("git", "describe", "--match=$pattern", "--abbrev=0", $commit);
Should not it use --first-parent? Otherwise there is risk to pick up wrong tag from merged branch.
That sounds like a good point, but Jan has since proposed a new design which uses a fixed base tag rather than --match, and hence eliminates any risk of picking up the wrong tag.
chomp(my $len = `git rev-list "$commit" | wc -l`);
Why not "git rev-list --count $commit"? (Same comment about --first-parent)
+1 :) -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org