Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 18680d611347d312142a0d3d0fd653694d575b0e
https://github.com/openSUSE/open-build-service/commit/18680d611347d312142a0d...
Author: Manuel Schnitzer
Date: 2017-09-25 (Mon, 25 Sep 2017)
Changed paths:
M ReleaseNotes-2.9
A src/api/db/migrate/20170925060940_allow_null_for_group_id_in_groups_users.rb
M src/api/db/structure.sql
A src/api/spec/controllers/group_controller_spec.rb
M src/api/spec/factories/groups.rb
Log Message:
-----------
[api] Fix deletion of groups with users
When using `dependent: :destroy`, rails first sets all foreign keys to
`NULL` and delete them afterwards. Since we prohibit `group_id` to be
`NULL` in our database structure, it fails with an `Mysql2::Error`.
```
SQL (0.7ms) UPDATE `groups_users` SET `groups_users`.`group_id` =
NULL WHERE `groups_users`.`group_id` = 1
(0.3ms) ROLLBACK
ActiveRecord::NotNullViolation: Mysql2::Error: Column 'group_id'
cannot be null: UPDATE `groups_users` SET `groups_users`.`group_id`
= NULL WHERE `groups_users`.`group_id` = 1
from (irb):3
```
Commit: 23d49f87fe62fc46d9e08eebc97d56ea039a9350
https://github.com/openSUSE/open-build-service/commit/23d49f87fe62fc46d9e08e...
Author: Manuel Schnitzer
Date: 2017-09-25 (Mon, 25 Sep 2017)
Changed paths:
M ReleaseNotes-2.9
A src/api/db/migrate/20170925060940_allow_null_for_group_id_in_groups_users.rb
M src/api/db/structure.sql
A src/api/spec/controllers/group_controller_spec.rb
M src/api/spec/factories/groups.rb
Log Message:
-----------
Merge pull request #3901 from mschnitzer/fix_group_deletion_bug
[api] Fix deletion of groups with users
Compare: https://github.com/openSUSE/open-build-service/compare/19e61a1c894f...23d49f...
