Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 1946ec1f3505bb56097a6054ee3c6ae009a4edf2
https://github.com/openSUSE/open-build-service/commit/1946ec1f3505bb56097a60...
Author: Stephan Kulow
Date: 2018-12-03 (Mon, 03 Dec 2018)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/app/models/review.rb
Log Message:
-----------
Untangle change_review_state function
Commit: 7e4487618dd33e604a10724f5a92ac68535b0d23
https://github.com/openSUSE/open-build-service/commit/7e4487618dd33e604a1072...
Author: Stephan Kulow
Date: 2018-12-03 (Mon, 03 Dec 2018)
Changed paths:
M src/api/test/functional/maintenance_test.rb
Log Message:
-----------
Fix what looks like an invalid expectation
When the request changes to 'new', the comment in the
state is not supposed to repeat the last reviewer's comment.
This is actually a bug I fixed in previous commit
Commit: 5c0561519843fd767a20deb879856e185e9c3a83
https://github.com/openSUSE/open-build-service/commit/5c0561519843fd767a20de...
Author: Stephan Kulow
Date: 2018-12-03 (Mon, 03 Dec 2018)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/app/models/event/request.rb
A src/api/app/models/event/request_reviews_done.rb
A src/api/app/models/event/review_changed.rb
M src/api/app/models/event/review_wanted.rb
Log Message:
-----------
Add 2 new events for review handling
opensuse.obs.request.review_changed is sent whenever a review was changed
opensuse.obs.request.reviews_done is sent when a request moves to :new
Fixes #4413
Commit: 8bd6bcd17288ccdb92a1088ff4f2801ef0d2c59b
https://github.com/openSUSE/open-build-service/commit/8bd6bcd17288ccdb92a108...
Author: Stephan Kulow
Date: 2018-12-03 (Mon, 03 Dec 2018)
Changed paths:
M src/api/spec/support/rabbitmq.rb
Log Message:
-----------
Support expectations on rabbitmq that are more complex
In this case the 2nd param is nil and the json has is returned,
so you can expect(body).to include...
Commit: 60126343c580a3a6403278d05d5cf629d87030aa
https://github.com/openSUSE/open-build-service/commit/60126343c580a3a6403278...
Author: Stephan Kulow
Date: 2018-12-03 (Mon, 03 Dec 2018)
Changed paths:
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_missing_by__paramter.yml
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_wrong_user.yml
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/moves_to_new.yml
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/sends_3_events.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_creator_doesn_t_have_permissions_for_the_target_project/1_8_2_3_1.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_creator_doesn_t_have_permissions_for_the_target_project/1_9_2_3_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_is_pending/1_8_2_1_1.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_is_pending/1_9_2_1_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_was_already_processed/1_8_2_2_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_8_1_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_8_1_2.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_1.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_2.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_12_1_4_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_12_1_1_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_12_1_2_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_12_1_3_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_12_2_1.yml
M src/api/spec/models/bs_request_spec.rb
M src/api/test/unit/bs_request_test.rb
Log Message:
-----------
Move test for reqest#change_review from minitest to rspec
There I can check for rabbitmq events
Commit: 5b5d74610f4974b131b7d2f4e585477eeda077a9
https://github.com/openSUSE/open-build-service/commit/5b5d74610f4974b131b7d2...
Author: Stephan Kulow
Date: 2018-12-03 (Mon, 03 Dec 2018)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/app/models/review.rb
Log Message:
-----------
Split 3 more functions out of change_review_state
Commit: 9db5311d774123c3d3d4fdd07374afb2f967544f
https://github.com/openSUSE/open-build-service/commit/9db5311d774123c3d3d4fd...
Author: Stephan Kulow
Date: 2018-12-04 (Tue, 04 Dec 2018)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/app/models/review.rb
M src/api/spec/models/bs_request_spec.rb
Log Message:
-----------
Work on review feedback
Commit: 05d86ec83eb1c0cd99e8027a32ca0a154f33bbd0
https://github.com/openSUSE/open-build-service/commit/05d86ec83eb1c0cd99e802...
Author: Stephan Kulow
Date: 2018-12-18 (Tue, 18 Dec 2018)
Changed paths:
M src/api/app/models/bs_request.rb
M src/api/app/models/event/request.rb
A src/api/app/models/event/request_reviews_done.rb
A src/api/app/models/event/review_changed.rb
M src/api/app/models/event/review_wanted.rb
M src/api/app/models/review.rb
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_missing_by__paramter.yml
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/raises_exception_on_wrong_user.yml
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/moves_to_new.yml
A src/api/spec/cassettes/BsRequest/_change_review_state/with_by_user_review/with_the_proper_reviewer/sends_3_events.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_creator_doesn_t_have_permissions_for_the_target_project/1_8_2_3_1.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_creator_doesn_t_have_permissions_for_the_target_project/1_9_2_3_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_is_pending/1_8_2_1_1.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_is_pending/1_9_2_1_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_auto_accept/when_the_request_was_already_processed/1_8_2_2_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_8_1_1.yml
R src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_8_1_2.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_1.yml
A src/api/spec/cassettes/BsRequest/auto_accept/_delayed_auto_accept/1_9_1_2.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_12_1_4_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_12_1_1_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_12_1_2_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_12_1_3_1.yml
A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_12_2_1.yml
M src/api/spec/models/bs_request_spec.rb
M src/api/spec/support/rabbitmq.rb
M src/api/test/functional/maintenance_test.rb
M src/api/test/unit/bs_request_test.rb
Log Message:
-----------
Merge pull request #6406 from coolo/add_review_done
Refactor change_review_state to be able to add new events to it
Compare: https://github.com/openSUSE/open-build-service/compare/172acac7c955...05d86e...
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
