Branch: refs/heads/master
Home: https://github.com/openSUSE/osc
Commit: fbea0ea729f8ef25da9295d9eff826c7caf54d73
https://github.com/openSUSE/osc/commit/fbea0ea729f8ef25da9295d9eff826c7caf54...
Author: Marcus Huewe
Date: 2020-11-28 (Sat, 28 Nov 2020)
Changed paths:
M osc/commandline.py
M osc/core.py
Log Message:
-----------
Avoid superfluous/excessive usage of _html_escape
When creating a new request via the core.Request.create method, there is
no need to escape the data that is assigned to the "description" attribute
of a core.Request instance. Internally, core.Request.create ensures that
the data, which is POSTed to the api, is correctly escaped (the escaping
is implicitly done by ET (see core.Request.to_str)). Manually escaping the
description results in a double escaping (the escaped description is
escaped by ET again) - this is not the desired behavior.
Analogously, there is no need to escape the data that is passed to the
message parameter of the core.create_submit_request function because
core.create_submit_request takes care of escaping it.
Fixes: #869 ("Silly encoding of htmlencodable entities")
Commit: 745dc1180d3b95cd30d777b516924409c14cc26f
https://github.com/openSUSE/osc/commit/745dc1180d3b95cd30d777b516924409c14cc...
Author: Marcus Huewe
Date: 2020-12-05 (Sat, 05 Dec 2020)
Changed paths:
M osc/commandline.py
M osc/core.py
Log Message:
-----------
Merge branch 'fix__html_escape_usage' of https://github.com/marcus-h/osc
Avoid superfluous/excessive usage of _html_escape.
Compare: https://github.com/openSUSE/osc/compare/5428c09cd7d7...745dc1180d3b
