Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: c9ec2d54d973cc1808d6664cfa368d7cdc1ac200
https://github.com/openSUSE/open-build-service/commit/c9ec2d54d973cc1808d666...
Author: Björn Geuken
Date: 2018-01-24 (Wed, 24 Jan 2018)
Changed paths:
M src/api/spec/controllers/webui/image_templates_controller_spec.rb
R src/api/spec/routing/webui/projects/image_templates.rb
Log Message:
-----------
[frontend] Replace routing spec with controller test
A rubocop-rspec cop was complaining about an offense that could not be
corrected, and was not added to the rubocop todo file.
There were a couple of issues with the spec (long version below), which
caused the test to never run in our test suite.
I decided to replace the routing test, because the feature switch we
were testing is defined on controller level. So with a routing test it
wouldn't be possible to touch / test this code.
The long version:
There were a couple of issues with the spec:
* The spec was not having a _spec.rb suffix and thus never run in our
test suite
* Fixing the wrong file name caused test failures because of calling
the controller in a non working way (expect(get: :image_templates))
* Fixing this would still cause test failures because of the usages of
Rails.application.reloader.reload!
Commit: ee74f883426777f7158a77cedf9f8a1c142a5bf7
https://github.com/openSUSE/open-build-service/commit/ee74f883426777f7158a77...
Author: Björn Geuken
Date: 2018-01-24 (Wed, 24 Jan 2018)
Changed paths:
M .rubocop.yml
M .rubocop_todo.yml
M .travis.yml
M src/api/Gemfile
M src/api/Gemfile.lock
Log Message:
-----------
[frontend] Add rubocop-rspec to OBS
rubocop-rspec is an extension of rubocop that provides rspec related
style cops.
rubocop-rspec project:
https://github.com/backus/rubocop-rspec
Kudos to @ana06 for finding this :gem:
Commit: bef6f0165d52f7c989f10d4b14c7f2fc84b2160c
https://github.com/openSUSE/open-build-service/commit/bef6f0165d52f7c989f10d...
Author: Björn Geuken
Date: 2018-01-26 (Fri, 26 Jan 2018)
Changed paths:
M .rubocop.yml
M .rubocop_todo.yml
M .travis.yml
M src/api/Gemfile
M src/api/Gemfile.lock
M src/api/spec/controllers/webui/image_templates_controller_spec.rb
R src/api/spec/routing/webui/projects/image_templates.rb
Log Message:
-----------
Merge pull request #4397 from bgeuken/add_rubocop-rspec
Add rubocop-rspec
Compare: https://github.com/openSUSE/open-build-service/compare/fce49912a251...bef6f0...
