Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 10e64aab00f286eb94e64c2903a1d4fc02cfbdc7
https://github.com/openSUSE/open-build-service/commit/10e64aab00f286eb94e64c...
Author: Victor Pereira
Date: 2019-05-31 (Fri, 31 May 2019)
Changed paths:
A src/api/spec/cassettes/BsRequestAction/_check_maintenance_release/last_patchinfo_is_not_build/1_7_3_1.yml
M src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_1.yml
M src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_2.yml
M src/api/spec/models/bs_request_action_spec.rb
Log Message:
-----------
Fix bs_request_action spec using User.current and increase coverage
After the change introduced by making User.current private and working
with User.session, User.session! instead, we forgot to refresh our
cassettes, which unsurprisingly, are failing when vcr is disabled.
The BsRequestAction model has in general a low spec coverage, so
extended it adding some missing specs
We disabled the vcr where it isnt necessary and deleted unecessary
cassettes
Co-authored-by: Henne Vogelsang
Commit: 07689d9fc255c070e7a4ec3608d38a860b4112eb
https://github.com/openSUSE/open-build-service/commit/07689d9fc255c070e7a4ec...
Author: Victor Pereira
Date: 2019-05-31 (Fri, 31 May 2019)
Changed paths:
M src/api/app/models/bs_request_action.rb
Log Message:
-----------
Refactor method check_maintenance_release after adding spec and remove
unecessary require
The `require 'api_error'` was unecessary since its loaded by the
autoload
Refactored the method `check_maintenance_release` giving some better
name to variables and inverting a check condition from `unless` to `if`
Commit: 9f70fafbec888a2f3f2946f48f5975141d706b36
https://github.com/openSUSE/open-build-service/commit/9f70fafbec888a2f3f2946...
Author: Victor Pereira
Date: 2019-06-03 (Mon, 03 Jun 2019)
Changed paths:
M src/api/app/models/bs_request_action.rb
A src/api/spec/cassettes/BsRequestAction/_check_maintenance_release/last_patchinfo_is_not_build/1_7_3_1.yml
M src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_1.yml
M src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_2.yml
M src/api/spec/models/bs_request_action_spec.rb
Log Message:
-----------
Merge pull request #7646 from vpereira/bs_request_action_refactoring
Bs request action (refactoring model and specs)
Compare: https://github.com/openSUSE/open-build-service/compare/e6420f358633...9f70fa...
