Fish completions for kubernetes-client
Hi, The kubernetes-client package does not come with completions for fish. There is a long history upstream and in the fish shell itself but with no real conclusion: - https://github.com/fish-shell/fish-shell/issues/5516 - https://github.com/kubernetes/kubernetes/issues/30763 - https://github.com/kubernetes/kubernetes/pull/58484 - https://github.com/kubernetes/kubectl/issues/576 In the meantime, there is a third-party completion script that works reasonably well: https://github.com/evanlucas/fish-kubectl-completions I would like to package and submit this completion. I see two options: - add it as a source to the kubernetes-1.20 package - submit it as a separate kubernetes-client-fish-completion package and add supplements as usual, but without version ranges. Any thoughts on whether this is desirable and which option would be preferred? Thanks, Robert
On Mon, Dec 14, 2020 at 8:58 AM Robert Munteanu <rombert@apache.org> wrote:
Hi,
The kubernetes-client package does not come with completions for fish. There is a long history upstream and in the fish shell itself but with no real conclusion:
- https://github.com/fish-shell/fish-shell/issues/5516 - https://github.com/kubernetes/kubernetes/issues/30763 - https://github.com/kubernetes/kubernetes/pull/58484 - https://github.com/kubernetes/kubectl/issues/576
In the meantime, there is a third-party completion script that works reasonably well:
https://github.com/evanlucas/fish-kubectl-completions
I would like to package and submit this completion. I see two options:
- add it as a source to the kubernetes-1.20 package - submit it as a separate kubernetes-client-fish-completion package and add supplements as usual, but without version ranges.
Any thoughts on whether this is desirable and which option would be preferred?
I imagine that completions are agnostic of kubectl versions, so the latter would make more sense to do (submit as separate package and have it Supplement kubernetes-client). -- 真実はいつも一つ！/ Always, there's only one truth!
On Mon, 2020-12-14 at 09:09 -0500, Neal Gompa wrote:
On Mon, Dec 14, 2020 at 8:58 AM Robert Munteanu <rombert@apache.org> wrote:
Hi,
The kubernetes-client package does not come with completions for fish. There is a long history upstream and in the fish shell itself but with no real conclusion:
- https://github.com/fish-shell/fish-shell/issues/5516 - https://github.com/kubernetes/kubernetes/issues/30763 - https://github.com/kubernetes/kubernetes/pull/58484 - https://github.com/kubernetes/kubectl/issues/576
In the meantime, there is a third-party completion script that works reasonably well:
https://github.com/evanlucas/fish-kubectl-completions
I would like to package and submit this completion. I see two options:
- add it as a source to the kubernetes-1.20 package - submit it as a separate kubernetes-client-fish-completion package and add supplements as usual, but without version ranges.
Any thoughts on whether this is desirable and which option would be preferred?
I imagine that completions are agnostic of kubectl versions, so the latter would make more sense to do (submit as separate package and have it Supplement kubernetes-client).
They are agnostic in the sense that there is a single set of completions in the third party package. Completions do change between k8s versions, e.g. `kubectl alpha debug` was introduced in 1.18 and graduated to `kubectl debug` in 1.20 . Thanks, Robert
On Mon, 2020-12-14 at 15:13 +0100, Robert Munteanu wrote:
On Mon, 2020-12-14 at 09:09 -0500, Neal Gompa wrote:
On Mon, Dec 14, 2020 at 8:58 AM Robert Munteanu <rombert@apache.org> wrote:
Hi,
The kubernetes-client package does not come with completions for fish. There is a long history upstream and in the fish shell itself but with no real conclusion:
- https://github.com/fish-shell/fish-shell/issues/5516 - https://github.com/kubernetes/kubernetes/issues/30763 - https://github.com/kubernetes/kubernetes/pull/58484 - https://github.com/kubernetes/kubectl/issues/576
In the meantime, there is a third-party completion script that works reasonably well:
https://github.com/evanlucas/fish-kubectl-completions
I would like to package and submit this completion. I see two options:
- add it as a source to the kubernetes-1.20 package - submit it as a separate kubernetes-client-fish-completion package and add supplements as usual, but without version ranges.
Any thoughts on whether this is desirable and which option would be preferred?
I imagine that completions are agnostic of kubectl versions, so the latter would make more sense to do (submit as separate package and have it Supplement kubernetes-client).
They are agnostic in the sense that there is a single set of completions in the third party package. Completions do change between k8s versions, e.g. `kubectl alpha debug` was introduced in 1.18 and graduated to `kubectl debug` in 1.20 .
Then I agree with Neal, my preference is still for submitting it as a seperate package. -- Richard Brown Linux Distribution Engineer - Future Technology Team Phone +4991174053-361 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, D-90409 Nuernberg (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
On Tue, 2021-01-05 at 15:44 +0100, Richard Brown wrote:
On Mon, 2020-12-14 at 15:13 +0100, Robert Munteanu wrote:
On Mon, 2020-12-14 at 09:09 -0500, Neal Gompa wrote:
On Mon, Dec 14, 2020 at 8:58 AM Robert Munteanu <rombert@apache.org> wrote:
Hi,
The kubernetes-client package does not come with completions for fish. There is a long history upstream and in the fish shell itself but with no real conclusion:
- https://github.com/fish-shell/fish-shell/issues/5516 - https://github.com/kubernetes/kubernetes/issues/30763 - https://github.com/kubernetes/kubernetes/pull/58484 - https://github.com/kubernetes/kubectl/issues/576
In the meantime, there is a third-party completion script that works reasonably well:
https://github.com/evanlucas/fish-kubectl-completions
I would like to package and submit this completion. I see two options:
- add it as a source to the kubernetes-1.20 package - submit it as a separate kubernetes-client-fish-completion package and add supplements as usual, but without version ranges.
Any thoughts on whether this is desirable and which option would be preferred?
I imagine that completions are agnostic of kubectl versions, so the latter would make more sense to do (submit as separate package and have it Supplement kubernetes-client).
They are agnostic in the sense that there is a single set of completions in the third party package. Completions do change between k8s versions, e.g. `kubectl alpha debug` was introduced in 1.18 and graduated to `kubectl debug` in 1.20 .
Then I agree with Neal, my preference is still for submitting it as a seperate package.
https://build.opensuse.org/request/show/863136 Thanks, Robert
participants (3)
-
Neal Gompa -
Richard Brown -
Robert Munteanu