Re: Fish completions for kubernetes-client

On Mon, 2020-12-14 at 09:09 -0500, Neal Gompa wrote:

On Mon, Dec 14, 2020 at 8:58 AM Robert Munteanu wrote:

...

Hi,

The kubernetes-client package does not come with completions for fish. There is a long history upstream and in the fish shell itself but with no real conclusion:

- https://github.com/fish-shell/fish-shell/issues/5516 - https://github.com/kubernetes/kubernetes/issues/30763 - https://github.com/kubernetes/kubernetes/pull/58484 - https://github.com/kubernetes/kubectl/issues/576

In the meantime, there is a third-party completion script that works reasonably well:

  https://github.com/evanlucas/fish-kubectl-completions

I would like to package and submit this completion. I see two options:

- add it as a source to the kubernetes-1.20 package - submit it as a separate kubernetes-client-fish-completion package and add supplements as usual, but without version ranges.

Any thoughts on whether this is desirable and which option would be preferred?

I imagine that completions are agnostic of kubectl versions, so the latter would make more sense to do (submit as separate package and have it Supplement kubernetes-client).

They are agnostic in the sense that there is a single set of completions in the third party package. Completions do change between k8s versions, e.g. `kubectl alpha debug` was introduced in 1.18 and graduated to `kubectl debug` in 1.20 . Thanks, Robert