[opensuse-kernel] CONFIG_STRICT_DEVMEM in x86_64/ec2 kernel
Hi all, In the openSUSE 13.1 kernel, all x86_64 kernel flavors had CONFIG_STRICT_DEVMEM disabled, except ec2 which had this option enabled. In the openSUSE 13.2 kernel (as well as the master and openSUSE-42.1 branches), all kernel flavors have CONFIG_STRICT_DEVMEM enabled, except x86_64/ec2 which has this option disabled (commit 0e71aa40.) In between, it had been disabled a first time (commit 8673f3f8) then re-enabled (commit a0984ed7.) The commit messages typically say "Update config files" without further detail so at this point I have no reason to believe that there is any intent or rationale behind the different setting for the ec2 kernel flavor. Thus I would like to align the ec2 setting with all other kernels, if there are no objections. * * * * * From: Jean Delvare <jdelvare@suse.de> Subject: config/x86_64/ec2: Align CONFIG_STRICT_DEVMEM CONFIG_STRICT_DEVMEM is enabled in every other kernel flavor, so enable it for x86_64/ec2 as well. --- config/x86_64/ec2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/config/x86_64/ec2 +++ b/config/x86_64/ec2 @@ -2253,7 +2253,7 @@ CONFIG_ASYNC_RAID6_TEST=m # CONFIG_TEST_FIRMWARE is not set # CONFIG_TEST_UDELAY is not set # CONFIG_SAMPLES is not set -# CONFIG_STRICT_DEVMEM is not set +CONFIG_STRICT_DEVMEM=y # CONFIG_X86_PTDUMP is not set CONFIG_DEBUG_RODATA=y # CONFIG_DEBUG_RODATA_TEST is not set -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 07.09.15 at 11:02, <jdelvare@suse.de> wrote: In the openSUSE 13.1 kernel, all x86_64 kernel flavors had CONFIG_STRICT_DEVMEM disabled, except ec2 which had this option enabled.
In the openSUSE 13.2 kernel (as well as the master and openSUSE-42.1 branches), all kernel flavors have CONFIG_STRICT_DEVMEM enabled, except x86_64/ec2 which has this option disabled (commit 0e71aa40.) In between, it had been disabled a first time (commit 8673f3f8) then re-enabled (commit a0984ed7.)
I'm fine with it being enabled where not in sync with other flavors (but please also take into consideration bug 843732), as your patch suggests you intend to do. I wouldn't necessarily welcome it getting disabled in 13.1 though. Jan -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Jan, Thanks for your quick reply. Le Monday 07 September 2015 à 04:28 -0600, Jan Beulich a écrit :
On 07.09.15 at 11:02, <jdelvare@suse.de> wrote: In the openSUSE 13.1 kernel, all x86_64 kernel flavors had CONFIG_STRICT_DEVMEM disabled, except ec2 which had this option enabled.
In the openSUSE 13.2 kernel (as well as the master and openSUSE-42.1 branches), all kernel flavors have CONFIG_STRICT_DEVMEM enabled, except x86_64/ec2 which has this option disabled (commit 0e71aa40.) In between, it had been disabled a first time (commit 8673f3f8) then re-enabled (commit a0984ed7.)
I'm fine with it being enabled where not in sync with other flavors (but please also take into consideration bug 843732), as your patch suggests you intend to do.
I've read the bug and I am not surprised, in fact I expected to find that kind of explanation in the git log and was surprised not to. However, given that CONFIG_STRICT_DEVMEM was consistently [1] enabled in SLE12 ans SLE12 SP1 meanwhile, I would guess (and hope) that software vendors have fixed their products by now. [1] Except for s390x/zfcpdump which does not have it; no idea if it's on purpose or an overlook.
I wouldn't necessarily welcome it getting disabled in 13.1 though.
I have no intention of touching 13.1 at this point. I plan to update master and 42.1, and maybe 13.2. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (2)
-
Jan Beulich -
Jean Delvare